After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739831 - Add nonglobal plugin loader support
Add nonglobal plugin loader support
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2014-11-08 22:24 UTC by Garrett Regier
Modified: 2014-11-20 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add nonglobal plugin loader support (15.85 KB, patch)
2014-11-08 22:26 UTC, Garrett Regier 		none Details | Review
Add nonglobal plugin loader support v2 (20.63 KB, patch)
2014-11-16 20:24 UTC, Garrett Regier 		committed Details | Review

Description Garrett Regier 2014-11-08 22:24:45 UTC 
Allow multiple threads to each have a PeasEngine and be used without internal locking. Also allow using lua5.1 plugins from multiple threads.
Comment 1 Garrett Regier 2014-11-08 22:26:12 UTC 
Created attachment 290241 [details] [review]
Add nonglobal plugin loader support

This also modifies the current multiple-thread extension test to run with both global and nonglobal plugin loaders. Should be a decent stress test that everything is works properly.
Comment 2 Garrett Regier 2014-11-16 20:24:16 UTC 
Created attachment 290812 [details] [review]
Add nonglobal plugin loader support v2

Replaced peas_engine_use_nonglobal_loaders() with peas_engine_new_with_nonglobal_loaders() and construct-only property.
Comment 3 Garrett Regier 2014-11-18 18:40:46 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-11-18 20:05:40 UTC 
Review of attachment 290812 [details] [review]:

I just overlooked it and yes after this change I think it is fine the patch. Thanks
Comment 5 Ignacio Casal Quinteiro (nacho) 2014-11-18 20:06:45 UTC 
Review of attachment 290812 [details] [review]:

See comments.

::: libpeas/peas-engine.c
@@ +565,3 @@
+   * If non-global plugin loaders should be used.
+   *
+   * See peas_engine_new_with_nonglobal_loaders() for more information.

one issue though here, don't you have to put the since?

@@ +1431,3 @@
+ *       plugin loaders are always global.
+ *
+ * Returns: a new instance of #PeasEngine that uses nonglobal loaders.

missing Since?
Comment 6 Garrett Regier 2014-11-20 07:06:46 UTC 
Yes they do, fixed! Thanks!