After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739712 - keyboard: Delay caribou daemon invocation until really needed
keyboard: Delay caribou daemon invocation until really needed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 741243 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-11-06 07:54 UTC by Daiki Ueno
Modified: 2014-12-26 04:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Delay caribou daemon invocation until really needed (3.30 KB, patch)
2014-11-06 07:55 UTC, Daiki Ueno 		none Details | Review
keyboard: Delay caribou daemon invocation until really needed (3.38 KB, patch)
2014-11-07 02:18 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2014-11-06 07:54:57 UTC 
Calling g_dbus_proxy_new without any flag means that the caribou
daemon will be launched through D-Bus activation, when creating
a proxy.  It smoked out some corner cases in caribou and at-spi2-core,
but generally it would be good to avoid creating unused process.

This patch delays the invocation until the "Run" method is called.
Comment 1 Daiki Ueno 2014-11-06 07:55:00 UTC 
Created attachment 290076 [details] [review]
keyboard: Delay caribou daemon invocation until really needed
Comment 2 Daiki Ueno 2014-11-07 02:18:32 UTC 
Created attachment 290129 [details] [review]
keyboard: Delay caribou daemon invocation until really needed

Calling g_dbus_proxy_new without any flag means that the caribou
daemon will be launched through D-Bus activation, when creating
a proxy.  It smoked out some corner cases in caribou and at-spi2-core,
but generally it would be good to avoid creating unused process.

This patch delays the invocation until the "Run" method is called.
--
Change from v1: clear this._daemonProxy after calling "Quit", so the proxy will be recreated on the next call of this._setupKeyboard.
Comment 3 Rui Matos 2014-11-07 17:00:31 UTC 
Review of attachment 290129 [details] [review]:

Looks good
Comment 4 Daiki Ueno 2014-11-07 21:56:36 UTC 
Attachment 290129 [details] pushed as cbfd6a8 - keyboard: Delay caribou daemon invocation until really needed
Comment 5 Daiki Ueno 2014-12-08 12:12:29 UTC 
*** Bug 741243 has been marked as a duplicate of this bug. ***