After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739671 - Add libnice.recipe and libnice-static.recipe, and include in gstreamer-1.0-net
Add libnice.recipe and libnice-static.recipe, and include in gstreamer-1.0-net
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-05 14:24 UTC by Nirbheek Chauhan
Modified: 2014-11-05 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libsrtp.recipe: Fix building on targets/hosts other than Linux (6.73 KB, patch)
2014-11-05 14:25 UTC, Nirbheek Chauhan
committed Details | Review
recipes/custom.py: Add support for SourceType.TARBALL (3.92 KB, patch)
2014-11-05 14:25 UTC, Nirbheek Chauhan
committed Details | Review
cerbero/packages/package.Package: Aggregate the files list in packages correctly (1.62 KB, patch)
2014-11-05 14:26 UTC, Nirbheek Chauhan
committed Details | Review
New recipes: libnice.recipe, libnice-static.recipe (3.90 KB, patch)
2014-11-05 14:26 UTC, Nirbheek Chauhan
needs-work Details | Review
New recipes: libnice.recipe, libnice-static.recipe (5.67 KB, patch)
2014-11-05 15:44 UTC, Nirbheek Chauhan
none Details | Review
New recipes: libnice.recipe, libnice-static.recipe (5.70 KB, patch)
2014-11-05 15:51 UTC, Nirbheek Chauhan
committed Details | Review

Description Nirbheek Chauhan 2014-11-05 14:24:14 UTC
The attached patches add recipes for libnice{,-static} and add gstnice/libnice to gstreamer-1.0-net.

Along the way, they also fix four issues:

1) libsrtp.recipe was building unversioned libraries, which caused them to not be included in the gstreamer-1.0-net package
2) libsrtp.recipe was building .so libraries regardless of the target platform
3) recipes/custom.py didn't have support for stype = TARBALL
4) Doing `files = ['libnice:libs', 'libnice:plugins_net']` meant only plugins_net would be included, which is counter-intuitive.
Comment 1 Nirbheek Chauhan 2014-11-05 14:25:25 UTC
Created attachment 290024 [details] [review]
libsrtp.recipe: Fix building on targets/hosts other than Linux
Comment 2 Nirbheek Chauhan 2014-11-05 14:25:42 UTC
Created attachment 290025 [details] [review]
recipes/custom.py: Add support for SourceType.TARBALL
Comment 3 Nirbheek Chauhan 2014-11-05 14:26:00 UTC
Created attachment 290026 [details] [review]
cerbero/packages/package.Package: Aggregate the files list in packages correctly
Comment 4 Nirbheek Chauhan 2014-11-05 14:26:16 UTC
Created attachment 290027 [details] [review]
New recipes: libnice.recipe, libnice-static.recipe
Comment 5 Sebastian Dröge (slomo) 2014-11-05 14:40:59 UTC
Comment on attachment 290027 [details] [review]
New recipes: libnice.recipe, libnice-static.recipe

libnice's build system has no support for static plugins yet, that would have to be added first.
Comment 6 Nirbheek Chauhan 2014-11-05 15:44:12 UTC
Created attachment 290033 [details] [review]
New recipes: libnice.recipe, libnice-static.recipe

The recipe now includes a patch by stormer to build static gst plugins in libnice.
Comment 7 Nirbheek Chauhan 2014-11-05 15:46:17 UTC
Comment on attachment 290033 [details] [review]
New recipes: libnice.recipe, libnice-static.recipe

I attached the patch too soon, I'll attach a fixed one in a bit. Sorry for the noise.
Comment 8 Nirbheek Chauhan 2014-11-05 15:51:47 UTC
Created attachment 290034 [details] [review]
New recipes: libnice.recipe, libnice-static.recipe

This patch actually works.
Comment 9 Sebastian Dröge (slomo) 2014-11-05 19:09:34 UTC
commit 67e259f37353baa0e760ca31c38296c2d5dbca9f
Author: Nirbheek Chauhan <nirbheek@centricular.com>
Date:   Tue Oct 14 19:43:42 2014 +0530

    New recipes: libnice.recipe, libnice-static.recipe
    
    Also add to the gstreamer-1.0-net package