GNOME Bugzilla – Bug 739482
[PATCH] core: better handle DHCP expiry/nak during initial lease acquisition
Last modified: 2015-01-12 15:51:03 UTC
I ran into this problem when using wwan connection. I previous attempt was successfull, NM caches leased state in leases file. Next time NM trying to reuse this. If NAK returned, then connection failed. So, to establish connection .lease files should be deleted.
Created attachment 289768 [details] Log messages from NM
Created attachment 292516 [details] Debug log from NetworkManager
(In reply to comment #2) > Created an attachment (id=292516) [details] > Debug log from NetworkManager (thanks for the logfile) For the record, this is the lease file that caused the problem: lease { interface "wlan0"; fixed-address 192.168.10.105; option subnet-mask 255.255.255.0; option dhcp-lease-time 604800; option routers 192.168.10.1; option dhcp-message-type 5; option dhcp-server-identifier 192.168.10.1; option domain-name-servers 192.168.10.1; renew 0 2014/12/14 15:59:43; rebind 3 2014/12/17 10:22:12; expire 4 2014/12/18 07:22:12; }
I've noticed this issue as well, with one specific router (it was a Zyxel). So if there's a fix and I have time to visit the owner of the router, I can test it.
Looks serious enough for nm-1.0, please consider.
Created attachment 292573 [details] [review] 0001-core-better-handle-DHCP-expiry-nak-during-initial-le.patch
Created attachment 292574 [details] [review] 0001-core-better-handle-DHCP-expiry-nak-during-initial-le.patch
Also confirmed on local network in a hopefully reproducible way, just started the same system on another laptop, thus with new MAC address.
Review of attachment 292574 [details] [review]: Looks good but no time to test right now.
(In reply to comment #7) > Created an attachment (id=292574) [details] [review] > 0001-core-better-handle-DHCP-expiry-nak-during-initial-le.patch LGTM, didn't test it though. This doesn't fix dhcpcd, does it?
(In reply to comment #10) > (In reply to comment #7) > > Created an attachment (id=292574) [details] [review] [details] [review] > > 0001-core-better-handle-DHCP-expiry-nak-during-initial-le.patch > > LGTM, didn't test it though. > > This doesn't fix dhcpcd, does it? I believe it should fix dhcpcd actually. I've seen some 'nak' logs in the past for dhcpcd, and that should now be treated as EXPIRE, which is ignored during initial IP configuration.
Pushed as 1172178ce659f705987c0840ddf142eab550eb5d