After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739474 - radiobutton: don't consider hidden buttons in the group for focus
radiobutton: don't consider hidden buttons in the group for focus
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkButton
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-11-01 00:22 UTC by Cosimo Cecchi
Modified: 2014-11-01 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
radiobutton: don't consider hidden buttons in the group for focus (1.33 KB, patch)
2014-11-01 00:22 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-11-01 00:22:27 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2014-11-01 00:22:30 UTC 
Created attachment 289764 [details] [review]
radiobutton: don't consider hidden buttons in the group for focus

When a GtkRadioButton has no focus, it will accept it when there is no
other active button in its group.
If the active button in the group is hidden, for example because the UI
desires not to have a default option pre-selected, currently the focus
will not be accepted, which is not desired behavior.

This commit changes the code to only consider visible buttons in the
group when checking whether another button is active.
Comment 2 Matthias Clasen 2014-11-01 15:31:33 UTC 
Review of attachment 289764 [details] [review]:

ok
Comment 3 Cosimo Cecchi 2014-11-01 17:10:20 UTC 
Thanks for the review.

Attachment 289764 [details] pushed as 276a510 - radiobutton: don't consider hidden buttons in the group for focus