After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739469 - Maximum size for color area default and swap icons on the toolbox
Maximum size for color area default and swap icons on the toolbox
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2014-10-31 22:07 UTC by Kevin Payne
Modified: 2018-05-24 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kevin Payne 2014-10-31 22:07:44 UTC
I have been helping someone working on a large icon theme for use on high-resolution displays.

I have found that there is a maximum size for the gimp-default-colors and gimp-swap-colors icons as used in the toolbox, which is smaller than the icons I would like to use in the menus.

Due to the fixed size requested for the color editor in toolbox_create_color_area in app\widgets\gimptoolbox.c :

  col_area = gimp_toolbox_color_area_create (toolbox, 54, 42);

and the limit set in gimp_fg_bg_editor_expose in app\widgets\gimpfgbgeditor.c :

  if (default_w < width / 2 && default_h < height / 2)

the outcome is that an icon greater than 20 pixels in height is not displayed.


So there are a couple of questions here:

1.  Is it sensible to have a fixed size for the color area on the tool box? and if not, what is an appropriate method to determine a suitable size given the requirement of supporting radically different monitor resolutions?

2. Should the icon sizes used on the front panel be set to GTK_ICON_SIZE_MENU as this is not a menu? Would GTK_ICON_SIZE_SMALL_TOOLBAR not be more suitable? and therefore more controllable separately from icons actually used on menus.
Comment 1 Michael Natterer 2014-11-21 23:17:08 UTC
1. I guess not, but i would still say the logic in gimpfgbgeditor is ok,
   we'd have to make the area size configurable.

2. These values are completely irrelevant in this case, we know we
   register the icon in menu size, and simply have to use the same
   GTK_ICON_SIZE_MENU to get to it. The code then looks at the size
   of the returned icon and uses that.
Comment 2 GNOME Infrastructure Team 2018-05-24 14:49:36 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/608.