After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739379 - Support GTK_POLICY_EXTERNAL
Support GTK_POLICY_EXTERNAL
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-29 23:37 UTC by Florian Müllner
Modified: 2014-10-30 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scroll-view: Support GTK_POLICY_EXTERNAL (5.28 KB, patch)
2014-10-29 23:37 UTC, Florian Müllner 		committed Details | Review
appDisplay: Use EXTERNAL scroll policy (1.11 KB, patch)
2014-10-29 23:38 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-10-29 23:37:53 UTC 
See patch.
Comment 1 Florian Müllner 2014-10-29 23:37:56 UTC 
Created attachment 289616 [details] [review]
scroll-view: Support GTK_POLICY_EXTERNAL

GTK+ added a new PolicyType which currently triggers compiler warnings
about unhandled values in switch statements. We also have a use case for
it already, so add support for the new policy type.
Comment 2 Florian Müllner 2014-10-29 23:38:03 UTC 
Created attachment 289617 [details] [review]
appDisplay: Use EXTERNAL scroll policy

Now that we support the new policy type, we can just use it instead
of hiding the scrollbar.
Comment 3 Rui Matos 2014-10-30 10:58:47 UTC 
Review of attachment 289616 [details] [review]:

Looks good
Comment 4 Rui Matos 2014-10-30 10:59:01 UTC 
Review of attachment 289617 [details] [review]:

yep
Comment 5 Florian Müllner 2014-10-30 11:17:54 UTC 
Attachment 289616 [details] pushed as 5fca85c - scroll-view: Support GTK_POLICY_EXTERNAL
Attachment 289617 [details] pushed as 5180ab2 - appDisplay: Use EXTERNAL scroll policy