After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739347 - build: Fix build failure from missing tracker-ontologies.h
build: Fix build failure from missing tracker-ontologies.h
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2014-10-29 11:06 UTC by Marcus Karlsson
Modified: 2014-10-29 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Configure log (187.78 KB, text/x-log)
2014-10-29 11:07 UTC, Marcus Karlsson
  Details
build: Fix build failure from missing tracker-ontologies.h (11.72 KB, patch)
2014-10-29 11:22 UTC, Marcus Karlsson
committed Details | Review

Description Marcus Karlsson 2014-10-29 11:06:33 UTC
I am unable to build the current head (8a36eeb7). The build stops at a missing tracker-ontologies.h.

tracker-writeback-taglib.c:29:50: fatal error: libtracker-common/tracker-ontologies.h: No such file or directory
 #include <libtracker-common/tracker-ontologies.h>

By looking at commit a4d60c19 it appears that the file has moved from libtracker-common to libtracker-sparql.
Comment 1 Marcus Karlsson 2014-10-29 11:07:58 UTC
Created attachment 289577 [details]
Configure log
Comment 2 Marcus Karlsson 2014-10-29 11:22:31 UTC
Created attachment 289579 [details] [review]
build: Fix build failure from missing tracker-ontologies.h

This patch updates the remaining places where tracker-ontologies.h is included. A number of defines were also renamed when the file was moved, so they are updated too.
Comment 3 Martyn Russell 2014-10-29 11:37:50 UTC
Comment on attachment 289579 [details] [review]
build: Fix build failure from missing tracker-ontologies.h

Hi there, thanks for the patch, please go ahead and apply this.

One thing I would note is that ideally, you should be including libtracker-sparql/tracker-sparql.h and not specific files from each sub-library in Tracker. Same goes for libtracker-common.

Sorry for the extra work with the PREFIX name changes, but everyone is duplicating this work and I thought it should be done properly! :)
Comment 4 Marcus Karlsson 2014-10-29 13:03:47 UTC
OK, thanks.

I am not sure what you mean by go ahead and apply this though. I don't have a git account if that is what you mean.
Comment 5 Martyn Russell 2014-10-29 16:41:38 UTC
Comment on attachment 289579 [details] [review]
build: Fix build failure from missing tracker-ontologies.h

I did mean push with git, but I can do it if you don't have an account.

Thanks for the patch! :)
Comment 6 Martyn Russell 2014-10-29 16:41:53 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.