After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739277 - GstGLFilter propose allocation pass uninitialized size to gst_query_add_allocation_pool
GstGLFilter propose allocation pass uninitialized size to gst_query_add_alloc...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-28 06:38 UTC by comicfans44
Modified: 2014-10-28 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description comicfans44 2014-10-28 06:38:45 UTC 
version I tested is 19f86b7

construct pipeline as videotestsrc ! glfilterblur name=filter1 ! glfilterblur name=filter2 ! glimagesink


gst_gl_filter_propose_allocation of filter2 takes branch as following:

860: (pool != NULL)  false

886: (pool == NULL && need_pool)  true

898: (decide_pool && GST_IS_GL_BUFFER_POOL (decide_pool)
        && gst_caps_is_equal_fixed (decide_caps, caps))  true  

      this block assign decide_pool to pool

917: if (pool)  true 
     gst_query_add_allocation_pool(query,pool,size,1,0) ---> size is not initialized here
Comment 1 Matthew Waters (ystreet00) 2014-10-28 07:06:30 UTC 
Thanks!

commit 28105a6e7da632dc03d2fe2d100d85a6f166ae9b
Author: Matthew Waters <matthew@centricular.com>
Date:   Tue Oct 28 18:01:27 2014 +1100

    glfilter: avoid uninitialized variable size when chaining multiple glfilters
    
    https://bugzilla.gnome.org/show_bug.cgi?id=739277

and 1.4 5181967da9de271f7144e35114a6b013ae228818