After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739226 - configure.ac: variable substitution is not compatible with dash
configure.ac: variable substitution is not compatible with dash
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-26 21:24 UTC by Alexander Tsoy
Modified: 2014-11-01 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-configure.ac-workaround-quoting-issues.patch (993 bytes, patch)
2014-10-26 21:24 UTC, Alexander Tsoy 		committed Details | Review

Description Alexander Tsoy 2014-10-26 21:24:10 UTC 
Created attachment 289386 [details] [review]
0001-configure.ac-workaround-quoting-issues.patch

The following substitution doesn't work in dash (note ^C - I've pressed Ctrl+C here):

$ BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-"\${libdir}/mozilla/plugins"}"
> ^C
$

Therefore I get a configure error:

checking whether gtk+-unix-print support is requested... yes
checking for GTKUNIXPRINT... yes
checking for EV_DAEMON... yes
checking for DESKTOP_SCHEMAS... yes
checking for PREVIEWER... yes
./configure: 19987: ./configure: Syntax error: "(" unexpected (expecting "fi")



The following one works in bash, ksh and dash:

BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-\${libdir\}/mozilla/plugins}"

but I decided to just replace it with conditional.
Comment 1 Carlos Garcia Campos 2014-11-01 09:13:22 UTC 
Comment on attachment 289386 [details] [review]
0001-configure.ac-workaround-quoting-issues.patch

Pushed, thanks!