After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739168 - facebook: Error getting identity: Could not parse response
facebook: Error getting identity: Could not parse response
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-25 12:41 UTC by Thomas Bechtold
Modified: 2014-10-29 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add username fallback (1.77 KB, patch)
2014-10-25 12:48 UTC, Thomas Bechtold 		needs-work Details | Review
facebook: Add fallback to get presentation id (1.65 KB, patch)
2014-10-29 16:12 UTC, Debarshi Ray 		committed Details | Review

Description Thomas Bechtold 2014-10-25 12:41:50 UTC 
I tried to setup a facebook account with 3.14.0 (on openSUSE) and got the following error:

Error creating account
Error getting identity: Could not parse response


The json object I get after I press the login button doesn't have an email field. That's why it fails. Fields which are available in my case are:

id,first_name,gender,last_name,link,locale,name,timezone,updated_time,username,verified,work

I suggest to use the username if an email is not available for presentation_identity.
Comment 1 Thomas Bechtold 2014-10-25 12:48:03 UTC 
Created attachment 289311 [details] [review]
Add username fallback
Comment 2 Debarshi Ray 2014-10-29 16:12:10 UTC 
Review of attachment 289311 [details] [review]:

Thanks for the patch Thomas. Looks good to me, except a few minor nits.

::: src/goabackend/goafacebookprovider.c
@@ +253,3 @@
   if (presentation_identity == NULL)
     {
+      // use username as fallback for presentation identity

The comment is redundant.

@@ +266,1 @@
     }

Stray, unrelated change.
Comment 3 Debarshi Ray 2014-10-29 16:12:59 UTC 
Created attachment 289597 [details] [review]
facebook: Add fallback to get presentation id

Fixed the above issues.