After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739155 - yacc syntax highlighting can't handle semantic values more than one digit long
yacc syntax highlighting can't handle semantic values more than one digit long
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.14.x
Other Linux
: Normal trivial
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-24 23:47 UTC by Michael Catanzaro
Modified: 2014-10-25 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yacc.lang: handle multidigit semantic values (958 bytes, patch)
2014-10-24 23:47 UTC, Michael Catanzaro 		needs-work Details | Review
yacc.lang: handle multidigit semantic values (1.51 KB, patch)
2014-10-25 14:29 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-10-24 23:47:29 UTC 
// test.y
%%
a :
    {
        $10
    }

In the example above, the entire $10 should be highlighted red, but only the $1 portion of it is.
Comment 1 Michael Catanzaro 2014-10-24 23:47:42 UTC 
Created attachment 289302 [details] [review]
yacc.lang: handle multidigit semantic values

A semantic value $n can have any number of digits. Highlight the entire
value, not just the first digit.
Comment 2 Sébastien Wilmet 2014-10-25 09:08:37 UTC 
Review of attachment 289302 [details] [review]:

Looks good, but please provide an example in tests/syntax-highlighting/.
Comment 3 Michael Catanzaro 2014-10-25 14:29:17 UTC 
Created attachment 289312 [details] [review]
yacc.lang: handle multidigit semantic values

A semantic value $n can have any number of digits. Highlight the entire
value, not just the first digit.
Comment 4 Sébastien Wilmet 2014-10-25 14:31:54 UTC 
Review of attachment 289312 [details] [review]:

Thanks.
Comment 5 Michael Catanzaro 2014-10-25 14:34:04 UTC 
Yay!

Attachment 289312 [details] pushed as dcbb3a9 - yacc.lang: handle multidigit semantic values