After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739046 - "Open in New Window" context menu item gone
"Open in New Window" context menu item gone
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-23 00:40 UTC by mitch.special
Modified: 2015-01-10 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to return 'Open in New Window' back (869 bytes, patch)
2014-11-19 05:43 UTC, Boris Egorov 		committed Details | Review

Description mitch.special 2014-10-23 00:40:58 UTC 
It looks like recently there was a regression and fix for context menu items disappearing (https://bugzilla.gnome.org/show_bug.cgi?id=732124). However, the "Open in New Window" context menu item still appears to be MIA.

I see that the `win.open-link-in-new-window` item is still being defined (since the fix of #732124) but is not being referenced in the source code anywhere.

Can we get that option back?
Comment 1 Germán Poo-Caamaño 2014-10-23 01:10:38 UTC 
Probably it was overlooked.  Do you have a patch to propose?
Comment 2 Boris Egorov 2014-11-19 05:41:08 UTC 
Looks like a typo in xml file. Code uses "open-link-new-window" string, but menu description has "open-link-in-window":

    $ ag open-link
    shell/ev-window.c
    545:    ev_window_set_action_enabled (ev_window, "open-link", !recent_view_mode);
    546:    ev_window_set_action_enabled (ev_window, "open-link-new-window", !recent_view_mode);
    4996:   action = g_action_map_lookup_action (G_ACTION_MAP (ev_window), "open-link");
    5005:   action = g_action_map_lookup_action (G_ACTION_MAP (ev_window), "open-link-new-window");
    5845:   { "open-link", ev_window_popup_cmd_open_link },
    5846:   { "open-link-new-window", ev_window_popup_cmd_open_link_new_window },

    shell/evince-menus.ui
    213:        <attribute name="action">win.open-link</attribute>
    228:        <attribute name="action">win.open-link-in-window</attribute>

I changed string in evince-menus.ui, now item 'Open in New Window' come back. I also checked all other actions in evince-menus.ui, looks like them all used in code.
Comment 3 Boris Egorov 2014-11-19 05:43:12 UTC 
Created attachment 290959 [details] [review]
Patch to return 'Open in New Window' back
Comment 4 Robert Roth 2015-01-05 20:17:23 UTC 
Review of attachment 290959 [details] [review]:

The patch indeed adds the Open in New window context menu item back. I don't know if this is related, but when closing the window opened with that context menu item, evince crashes with the following backtrace, could anyone else please check if you get the same behaviour with this patch applied?

(gdb) backtrace

+ Trace 234503

  • #0 g_type_check_instance_cast
    at gtype.c line 4060
  • #1 ev_page_accessible_ref_state_set
    at ev-page-accessible.c line 288
  • #2 spi_atk_state_to_dbus_array
    from /lib64/libatk-bridge-2.0.so.0
  • #3 impl_GetState
    from /lib64/libatk-bridge-2.0.so.0
  • #4 handle_message
    from /lib64/libatk-bridge-2.0.so.0
  • #5 _dbus_object_tree_dispatch_and_unlock
    from /lib64/libdbus-1.so.3
  • #6 dbus_connection_dispatch
    from /lib64/libdbus-1.so.3
  • #7 message_queue_dispatch
    from /lib64/libatspi.so.0
  • #8 g_main_dispatch
    at gmain.c line 3122
  • #9 g_main_context_dispatch
    at gmain.c line 3721
  • #10 g_main_context_iterate
    at gmain.c line 3792
  • #11 g_main_context_iteration
    at gmain.c line 3853
  • #12 g_application_run
    at gapplication.c line 2282
  • #13 main
    at main.c line 316 






Comment 5


Boris Egorov





          2015-01-05 20:51:44 UTC
        



(In reply to comment #4)
> Review of attachment 290959 [details] [review]:
> 
> The patch indeed adds the Open in New window context menu item back. I don't
> know if this is related, but when closing the window opened with that context
> menu item, evince crashes with the following backtrace, could anyone else
> please check if you get the same behaviour with this patch applied?
> 
> (gdb) backtrace
> 

I can't reproduce a crash.






Comment 6


Carlos Garcia Campos





          2015-01-10 10:00:14 UTC
        



Review of attachment 290959 [details] [review]:

The patch looks correct. I've just pushed it to git master. Thanks!