After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738920 - dashdemux: allow seek to be performed if all streams are EOS
dashdemux: allow seek to be performed if all streams are EOS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-21 11:06 UTC by Matthieu Bouron
Modified: 2014-12-12 00:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: allow seek to be performed if all streams are EOS (1.54 KB, patch)
2014-10-21 11:07 UTC, Matthieu Bouron 		none Details | Review
dashdemux: allow seek to be performed if all streams are EOS (1.53 KB, patch)
2014-10-21 11:12 UTC, Matthieu Bouron 		needs-work Details | Review

Description Matthieu Bouron 2014-10-21 11:06:11 UTC 
After playing a dash stream in reverse playback and reaching the beginning of the file (EOS), seeking at the beginning of the stream can be discarded as the segment position is the same as the seek position.
Comment 1 Matthieu Bouron 2014-10-21 11:07:02 UTC 
Created attachment 289017 [details] [review]
dashdemux: allow seek to be performed if all streams are EOS
Comment 2 Matthieu Bouron 2014-10-21 11:12:30 UTC 
Created attachment 289018 [details] [review]
dashdemux: allow seek to be performed if all streams are EOS

Whitespaces noise fixed.
Comment 3 Thiago Sousa Santos 2014-11-07 13:54:42 UTC 
Review of attachment 289018 [details] [review]:

Nice catch, but I guess the issue is more generic than just for EOS. The logic for doing the seek is a bit wrong in dashdemux (and likely in mssdemux).

For example, it should always send flushes if the seek is a flushing seek even when the position won't change. So, while we are here, how about fixing this all to work correctly? I'd recommend taking a look at pull mode seeking in some stable element like qtdemux.
Comment 4 Thiago Sousa Santos 2014-12-12 00:18:29 UTC 
commit 75b0bac7f8ed9a4f54fb73d4542cce39a9dc4c6c
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Thu Dec 11 21:01:48 2014 -0300

    adaptivedemux: fix seek event handling
    
    Properly do seeking and avoid only seeking when the segment was updated.
    It would cause seeks after the stream was EOS to fail, for example.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738920