After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738875 - Build failure with SELinux and introspection enabled
Build failure with SELinux and introspection enabled
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-20 15:14 UTC by Matthew Barnes
Modified: 2014-10-20 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (821 bytes, patch)
2014-10-20 15:14 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2014-10-20 15:14:52 UTC
Created attachment 288954 [details] [review]
Proposed patch

Building ostree from git (2014.8) with SELinux and introspection enabled, the GISCAN phase for libostree failed for me:

  GISCAN   OSTree-1.0.gir
./.libs/libostree-1.so: undefined reference to `selabel_close'
./.libs/libostree-1.so: undefined reference to `lsetfilecon'
./.libs/libostree-1.so: undefined reference to `selabel_lookup_raw'
./.libs/libostree-1.so: undefined reference to `freecon'
./.libs/libostree-1.so: undefined reference to `selabel_open'
./.libs/libostree-1.so: undefined reference to `lgetfilecon_raw'
./.libs/libostree-1.so: undefined reference to `selinux_set_policy_root'
collect2: error: ld returned 1 exit status
make[2]: *** [ostree] Error 1

Trying to follow your automake style, I got past it with the attached patch.
Comment 1 Colin Walters 2014-10-20 16:39:05 UTC
Review of attachment 288954 [details] [review]:

Strange, not sure why I'm not hitting that myself.  I bet this is a newer automake issue, similar to:

https://git.gnome.org/browse/ostree/commit/?id=1242704d68f6125f8b76850704e014b7dcd788ab

Can you just tweak the commit message style to match?  Topic prefix "build", no trailing '.'. Should look like:

build: Include SELinux cflags with libostree build too

This is likely another issue with newer automake.

https://bugzilla.gnome.org/738875
Comment 2 Matthew Barnes 2014-10-20 19:27:38 UTC
Pushed with the suggested commit message.

https://git.gnome.org/browse/ostree/commit/?id=a4d904ee38614918d9a7be2a245c179c39661e72