After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738626 - bluez: Does not support bluez5 yet
bluez: Does not support bluez5 yet
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-16 11:04 UTC by Nick Stoughton
Modified: 2014-12-11 03:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initial patch for update to (UNTESTED) (2.71 KB, patch)
2014-10-16 11:04 UTC, Nick Stoughton 		none Details | Review
Updated patch for compile-time distinction between bluez4 and 5 (3.87 KB, patch)
2014-12-09 16:49 UTC, Nick Stoughton 		committed Details | Review
bluez: support compile-time distinction between bluez4 and bluez5 (3.82 KB, patch)
2014-12-11 03:39 UTC, Arun Raghavan 		committed Details | Review

Description Nick Stoughton 2014-10-16 11:04:44 UTC 
Created attachment 288671 [details] [review]
Initial patch for update to (UNTESTED)

The current version of the bluez plugin is based on the MediaTransport interface of bluez4. With the introduction of bluez5, this interface has been replaced by MediaTransport1, which is slightly different.

Attached is a first pass (untested) of a patch to implement this change.
Comment 1 Sebastian Dröge (slomo) 2014-10-21 08:50:51 UTC 
That looks quite simple but probably is not enough. Also if it's that simple we should try to support 4 and 5 with some #ifdefs
Comment 2 Nick Stoughton 2014-12-09 16:49:33 UTC 
Created attachment 292394 [details] [review]
Updated patch for compile-time distinction between bluez4 and 5
Comment 3 Nick Stoughton 2014-12-09 16:52:50 UTC 
Sorry ... forgot to add, this patch has now been tested and appears to work. Still to do: use dbus introspection to make this a run-time determination. However, for most people, this should prove adequate.
Comment 4 Nicolas Dufresne (ndufresne) 2014-12-09 16:56:48 UTC 
Any reason this is targetting 2.X ?
Comment 5 Nick Stoughton 2014-12-09 17:10:16 UTC 
No, but it has only been tested there.
Comment 6 Nicolas Dufresne (ndufresne) 2014-12-09 17:11:17 UTC 
Fixed ;-P
Comment 7 Arun Raghavan 2014-12-11 03:38:48 UTC 
The following fix has been pushed:
a344b99 bluez: support compile-time distinction between bluez4 and bluez5
Comment 8 Arun Raghavan 2014-12-11 03:39:10 UTC 
Created attachment 292506 [details] [review]
bluez: support compile-time distinction between bluez4 and bluez5

Signed-off-by: Nick Stoughton <nstoughton@aether.com>