After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738616 - build-sys: Don't set GConf flags when it's disabled
build-sys: Don't set GConf flags when it's disabled
Status: RESOLVED WONTFIX
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-16 09:39 UTC by Christophe Fergeau
Modified: 2017-11-16 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build-sys: Don't set GConf flags when it's disabled (1.66 KB, patch)
2014-10-16 09:39 UTC, Christophe Fergeau 		reviewed Details | Review
build-sys: Remove unused GConf preprocessor #defines (933 bytes, patch)
2014-10-16 09:47 UTC, Christophe Fergeau 		reviewed Details | Review
build-sys: Remove unused GTKBUILDER_DIR #define (855 bytes, patch)
2014-10-16 09:47 UTC, Christophe Fergeau 		reviewed Details | Review

Description Christophe Fergeau 2014-10-16 09:39:16 UTC 
We currently always call PKG_CHECK_MODULES(GCONF, gconf-2.0) even when
configure was called with --disable-gconf.
If GConf development packages were installed, this will cause
GCONF_CFLAGS/GCONF_LIBS to be set even though it's disabled, and the
resulting gnome-session binary will end up linking with gconf.

This patch reworks a little bit the GConf detection code so that it only
calls PKG_CHECK_MODULES when GConf is enabled or auto-detected.
Comment 1 Christophe Fergeau 2014-10-16 09:39:21 UTC 
Created attachment 288658 [details] [review]
build-sys: Don't set GConf flags when it's disabled
Comment 2 Christophe Fergeau 2014-10-16 09:47:28 UTC 
Created attachment 288661 [details] [review]
build-sys: Remove unused GConf preprocessor #defines
Comment 3 Christophe Fergeau 2014-10-16 09:47:36 UTC 
Created attachment 288662 [details] [review]
build-sys: Remove unused GTKBUILDER_DIR #define
Comment 4 Michael Catanzaro 2016-09-13 21:26:26 UTC 
We should just delete the gconf support; surely nobody wants that anymore?
Comment 5 Christophe Fergeau 2016-09-14 07:20:29 UTC 
Unless it's used for backward compatibility/migration purpose when moving from gnome 2 to gnome 3, this shoud probably be dropped indeed. Even if it's there for such purpose, it probably has been enough time that this could be dropped anyway.
Comment 6 Bastien Nocera 2017-11-16 13:52:35 UTC 
Review of attachment 288658 [details] [review]:

Added a patch in bug 787806 to remove it altogether.
Comment 7 Bastien Nocera 2017-11-16 13:52:50 UTC 
Review of attachment 288661 [details] [review]:

Ditto.
Comment 8 Bastien Nocera 2017-11-16 13:53:12 UTC 
Review of attachment 288662 [details] [review]:

And merged this in the meson porting patch in bug 787806.
Comment 9 Bastien Nocera 2017-11-16 13:54:50 UTC 
All 3 patches should be taken care of in bug 787806, so closing this. Thanks for the pointers!