After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738536 - layout: Reset the OSK to the primary monitor when monitors change
layout: Reset the OSK to the primary monitor when monitors change
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-14 16:02 UTC by Rui Matos
Modified: 2014-10-16 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
layout: Reset the OSK to the primary monitor when monitors change (1.32 KB, patch)
2014-10-14 16:02 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2014-10-14 16:02:02 UTC 
Couldn't think of a good way to try and keep the OSK on the same
monitor where it was in case the indices have changed. In any case I
don't think it'd be worth the trouble.
Comment 1 Rui Matos 2014-10-14 16:02:05 UTC 
Created attachment 288533 [details] [review]
layout: Reset the OSK to the primary monitor when monitors change

When monitors change, the previous index might not mean the same
physical monitor anymore, in fact, it might become invalid. In the
latter case, we'll actually get a JS error when accessing
this.keyboardMonitor in _updateKeyboardBox() . To avoid this, let's
just always reset the OSK to the primary monitor.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-10-14 18:33:27 UTC 
Review of attachment 288533 [details] [review]:

Sure.
Comment 3 Rui Matos 2014-10-16 14:43:11 UTC 
Attachment 288533 [details] pushed as 01eb79a - layout: Reset the OSK to the primary monitor when monitors change