After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738262 - The find button crashes Evince in those backends that don't implement the find option
The find button crashes Evince in those backends that don't implement the fin...
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 739473 741759 771247 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-10-09 21:20 UTC by Juanjo Marín
Modified: 2018-02-23 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.46 KB, patch)
2014-10-09 21:40 UTC, Juanjo Marín 		reviewed Details | Review

Description Juanjo Marín 2014-10-09 21:20:36 UTC 
The comics and tiff backends don't implement the find function, however, the find button is enabled in the toolbar for those type of files and it crashes Evince if pressed.
Comment 1 Juanjo Marín 2014-10-09 21:40:45 UTC 
Created attachment 288175 [details] [review]
Proposed patch

I submit a patch for review :-)
Comment 2 Germán Poo-Caamaño 2014-10-09 22:22:40 UTC 
Review of attachment 288175 [details] [review]:

::: shell/ev-window.c
@@ +457,1 @@
 	}

I don't think this is the right approach.  In this part of the code, it is only getting the capabilities of the document.

The issue seems to be later, ~503:

ev_window_set_action_enabled (ev_window, "find", can_find &&
				      !recent_view_mode);

Check if can_find is being set correctly, otherwise the error is in the condition (possibly introduced when we added the recent view mode).
Comment 3 Juanjo Marín 2014-10-09 22:40:33 UTC 
I think can_find is set correctly. I guess the error must be in the gaction definition, but this concept is new to me and I need time to learn.
 
I'll be offline till monday, so I'm affraid I won't be able to fix this for the 3.14.1 release :/
Comment 4 Carlos Garcia Campos 2014-10-19 13:24:56 UTC 
Review of attachment 288175 [details] [review]:

::: shell/ev-window.c
@@ +457,1 @@
 	}

The problem is that the find action is the one used by the accelerator, the toggle button one is toggle-find, and we are not enabling/disabling that action here.
Comment 5 Carlos Garcia Campos 2014-10-19 13:25:59 UTC 
Fixed in git master now.
Comment 6 Juanjo Marín 2014-10-19 14:43:16 UTC 
Good catch ! :-)
Comment 7 Carlos Garcia Campos 2014-11-01 09:09:08 UTC 
*** Bug 739473 has been marked as a duplicate of this bug. ***
Comment 8 Hong Xu 2015-07-06 03:47:57 UTC 
It looks like this problem still persists for DVI?
Comment 9 Jason Crain 2016-09-11 14:16:59 UTC 
*** Bug 771247 has been marked as a duplicate of this bug. ***
Comment 10 Jason Crain 2018-02-23 16:18:55 UTC 
*** Bug 741759 has been marked as a duplicate of this bug. ***