After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738238 - wayland-keyboard: Send modifiers after the key event
wayland-keyboard: Send modifiers after the key event
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-09 15:11 UTC by Rui Matos
Modified: 2014-10-10 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland-keyboard: Send modifiers after the key event (2.48 KB, patch)
2014-10-09 15:11 UTC, Rui Matos 		committed Details | Review

Comment 1 Rui Matos 2014-10-09 15:11:05 UTC 
Created attachment 288139 [details] [review]
wayland-keyboard: Send modifiers after the key event

The key event should be interpreted by clients with the modifier state
as it was before the event itself just as in X11 input events.
Achieving this in wayland is a matter of sending the key event first
and the modifiers after (if needed).

This isn't really specified in the wayland protocol but it matches
weston's behavior and should avoid corner cases in clients.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-10-09 17:25:59 UTC 
Review of attachment 288139 [details] [review]:

Looks good.
Comment 3 Rui Matos 2014-10-10 16:32:26 UTC 
Attachment 288139 [details] pushed as 4040a70 - wayland-keyboard: Send modifiers after the key event