After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737846 - Support disable-save-to-disk lockdown setting
Support disable-save-to-disk lockdown setting
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-03 15:02 UTC by Florian Müllner
Modified: 2014-10-03 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screencast: Don't leak recorders on failure (1.38 KB, patch)
2014-10-03 15:02 UTC, Florian Müllner 		committed Details | Review
screencast: Re-add lockdown support (1.77 KB, patch)
2014-10-03 15:02 UTC, Florian Müllner 		committed Details | Review
screenshot: Respect lockdown settings (1.27 KB, patch)
2014-10-03 15:02 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-10-03 15:02:14 UTC 
See patches. The recorder lost support for this at some point, and we just ignored it for screenshots so far ..
Comment 1 Florian Müllner 2014-10-03 15:02:17 UTC 
Created attachment 287676 [details] [review]
screencast: Don't leak recorders on failure

ShellRecorder.record() may fail, remove the recorder from the map
in that case.
Comment 2 Florian Müllner 2014-10-03 15:02:24 UTC 
Created attachment 287677 [details] [review]
screencast: Re-add lockdown support

Commit 81bb7009ea120d3 removed support for the disable-disk-writes
lockdown feature for screencasts, add it back.
Comment 3 Florian Müllner 2014-10-03 15:02:29 UTC 
Created attachment 287678 [details] [review]
screenshot: Respect lockdown settings

We allow users/admins to lock down disk writes, respect that when
taking screenshots.
Comment 4 drago01 2014-10-03 15:04:23 UTC 
Review of attachment 287676 [details] [review]:

OK.
Comment 5 drago01 2014-10-03 15:05:04 UTC 
Review of attachment 287677 [details] [review]:

OK.
Comment 6 drago01 2014-10-03 15:05:35 UTC 
Review of attachment 287678 [details] [review]:

OK.
Comment 7 Florian Müllner 2014-10-03 15:09:30 UTC 
Attachment 287676 [details] pushed as 4ed4bb3 - screencast: Don't leak recorders on failure
Attachment 287677 [details] pushed as dd42cfa - screencast: Re-add lockdown support
Attachment 287678 [details] pushed as f9d909f - screenshot: Respect lockdown settings