After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737603 - v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 726195 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-09-29 16:51 UTC by Aurélien Zanelli
Modified: 2014-12-09 19:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED (1.66 KB, patch)
2014-09-29 16:53 UTC, Aurélien Zanelli 		reviewed Details | Review
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED (1.62 KB, patch)
2014-12-09 13:10 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-09-29 16:51:08 UTC 
Currently the dqbuf method only set interlace flags when v4l2_buffer.field is
V4L2_FIELD_INTERLACED_TB or V4L2_FIELD_INTERLACED_BT.

I prepared a patch which handle the V4L2_FIELD_INTERLACED case.
Comment 1 Aurélien Zanelli 2014-09-29 16:53:36 UTC 
Created attachment 287378 [details] [review]
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED

If v4l2_buffer.field is V4L2_FIELD_INTERLACED, we set corresponding GstVideoBuffer flags depending on the video standard.
According to V4L2 specification, M/NTSC transmits the bottom field first, all other standards the top field first.
Comment 2 Tim-Philipp Müller 2014-09-29 19:52:37 UTC 
This looks like a duplicate of bug #726195	 , also see bug #726194.
Comment 3 Aurélien Zanelli 2014-09-29 20:07:25 UTC 
Yes it is about the same topic.
Can you mark my bug as duplicate, it seems I can't.
Comment 4 Sebastian Dröge (slomo) 2014-09-30 08:42:53 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 726195 ***
Comment 5 Nicolas Dufresne (ndufresne) 2014-12-08 23:32:14 UTC 
*** Bug 726195 has been marked as a duplicate of this bug. ***
Comment 6 Nicolas Dufresne (ndufresne) 2014-12-08 23:33:30 UTC 
Review of attachment 287378 [details] [review]:

This one actually looks good to me, instead of just complaining it sets some sensible default. This is most likely backward compatible too. I'd merge this one if no objection ?
Comment 7 Aurélien Zanelli 2014-12-09 09:42:00 UTC 
No objection at all, but I'm not sure it will apply on master since it could overlap with https://bugzilla.gnome.org/show_bug.cgi?id=726194 (commit 02040d507cc4a3d4d22fab15b8bdf1d3746ea26f)

However I can rework it and test it.
Comment 8 Aurélien Zanelli 2014-12-09 13:10:00 UTC 
Created attachment 292383 [details] [review]
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED

rebased on master
Comment 9 Nicolas Dufresne (ndufresne) 2014-12-09 19:45:26 UTC 
1.5 commit 621931
1.4 commit a4ce8e