GNOME Bugzilla – Bug 737579
v4l2object: set colorspace for output devices
Last modified: 2014-12-16 00:01:32 UTC
When the v4l2 device is an output device, the application shall set the colorspace. So I modify the gst_v4l2_object_set_format() to map GStreamer colorimetry info to V4L2 colorspace for output devices. If we have no colorimetry information, I try to guess it using the pixelformat (YUV or RGB) and the video width and height.
Created attachment 287338 [details] [review] v4l2object: set colorspace for output devices Patch proposal
Review of attachment 287338 [details] [review]: Look good to me, thanks for the patch (and taking the time to figure-out he equivalence, I'll merge later today).
Comment on attachment 287338 [details] [review] v4l2object: set colorspace for output devices commit cfb4c021871ae65a8836401768c1b816229c1191 Author: Aurélien Zanelli <aurelien.zanelli@parrot.com> Date: Mon Sep 29 11:49:45 2014 +0200 v4l2object: set colorspace for output devices When the v4l2 device is an output device, the application shall set the colorspace. So map GStreamer colorimetry info to V4L2 colorspace and set on set_format. In case we have no colorimetry information, we try to guess it according to pixel format and video size. https://bugzilla.gnome.org/show_bug.cgi?id=737579
Thanks.
Backported to 1.4 commit 1a9bb902553fafb4a957f207449626d6a9e0aa87 Author: Aurélien Zanelli <aurelien.zanelli@parrot.com> Date: Mon Sep 29 11:49:45 2014 +0200 v4l2object: set colorspace for output devices When the v4l2 device is an output device, the application shall set the colorspace. So map GStreamer colorimetry info to V4L2 colorspace and set on set_format. In case we have no colorimetry information, we try to guess it according to pixel format and video size. https://bugzilla.gnome.org/show_bug.cgi?id=737579