After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737560 - [review] lr/bluetooth: Add support for editing Bluetooth connections
[review] lr/bluetooth: Add support for editing Bluetooth connections
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2014-09-29 05:56 UTC by Lubomir Rintel
Modified: 2015-04-15 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] editor: Add support for editing Bluetooth connections (12.82 KB, patch)
2014-09-29 05:56 UTC, Lubomir Rintel 		none Details | Review

Description Lubomir Rintel 2014-09-29 05:56:30 UTC 
Created attachment 287319 [details] [review]
[PATCH] editor: Add support for editing Bluetooth connections

Only existing DUN & PAN connections, no creation of new ones.
Comment 1 Jiri Klimes 2014-09-29 09:17:49 UTC 
I have pushed two fixup commits. See https://git.gnome.org/browse/network-manager-applet/log/?h=jk/bluetooth-editor

You should add Bluetooth type to the editor as well, probably as a combo box.
Comment 2 Lubomir Rintel 2014-10-10 08:21:07 UTC 
(In reply to comment #1)
> I have pushed two fixup commits. See
> https://git.gnome.org/browse/network-manager-applet/log/?h=jk/bluetooth-editor

First one seems fine, while the other does not. It's not so simple to add a new bluetooth connection as you need to choose whether it's PAN or DUN and if it's dun then pick GSM or CDMA and run the broadband wizart. That's the reason I omitted it for mow.

> You should add Bluetooth type to the editor as well, probably as a combo box.

Does not make sense to me. It's complex enough to be determined at creation time (see above) and the devices don't turn from PAN to DUN or vice versa anyway.
Comment 3 Jiri Klimes 2014-10-13 16:51:13 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > I have pushed two fixup commits. See
> > https://git.gnome.org/browse/network-manager-applet/log/?h=jk/bluetooth-editor
> 
> First one seems fine, while the other does not. It's not so simple to add a new
> bluetooth connection as you need to choose whether it's PAN or DUN and if it's
> dun then pick GSM or CDMA and run the broadband wizart. That's the reason I
> omitted it for mow.
> 
I don't think we would necessarily need to run the wizard for DUN. The main details for GSM/CDMA could be filled manually and let the user complete the rest. Sure, we would have to ask for the type first, and then add gsm or cdma settings if it is DUN.

> > You should add Bluetooth type to the editor as well, probably as a combo box.
> 
> Does not make sense to me. It's complex enough to be determined at creation
> time (see above) and the devices don't turn from PAN to DUN or vice versa
> anyway.
If we don't want to support type changing then asking at connection creation type is sufficient.

But if you prefer, leave it for later updates.
Comment 4 Lubomir Rintel 2014-10-27 11:13:09 UTC 
lr/bluetooth branch: https://git.gnome.org/browse/network-manager-applet/log/?h=lr/bluetooth
Comment 5 Jiri Klimes 2015-04-15 09:21:59 UTC 
Pushed a fixup, otherwise it looks good to me.
Comment 6 Lubomir Rintel 2015-04-15 12:16:09 UTC 
9b292e0 ui: merge branch 'lr/bluetooth'
6df2262 editor: Add support for creating Bluetooth connections