After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737386 - dark adwaita's -GtkWidget-link-color is unreadable on gray background
dark adwaita's -GtkWidget-link-color is unreadable on gray background
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-09-25 19:58 UTC by kapouer
Modified: 2014-09-29 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing #737386 (782 bytes, patch)
2014-09-25 19:59 UTC, kapouer 		none Details | Review
screenshot before the patch (35.07 KB, image/png)
2014-09-25 23:17 UTC, kapouer 		  Details
screenshot after the patch (43.91 KB, image/png)
2014-09-25 23:17 UTC, kapouer 		  Details
make dark links lighter/legible (2.72 KB, patch)
2014-09-26 13:39 UTC, Jakub Steiner 		none Details | Review
Fixes link style (10.05 KB, patch)
2014-09-26 15:10 UTC, Lapo Calamandrei 		none Details | Review
Fixes link style (10.73 KB, patch)
2014-09-26 16:28 UTC, Lapo Calamandrei 		rejected Details | Review

Description kapouer 2014-09-25 19:58:20 UTC 
Hi,

this typically happens in evolution when switching dark theme on.
Here's another color that does the job at being readable.
Comment 1 kapouer 2014-09-25 19:59:40 UTC 
Created attachment 287108 [details] [review]
patch fixing #737386
Comment 2 Lapo Calamandrei 2014-09-25 22:57:22 UTC 
Would you attach a screenshot of the issue, please.
Comment 3 Lapo Calamandrei 2014-09-25 23:01:25 UTC 
I had the css for the notebook, but there ws some problem I don't remember right now, maybe not working animations in tab?
Comment 4 kapouer 2014-09-25 23:17:09 UTC 
Created attachment 287117 [details]
screenshot before the patch
Comment 5 kapouer 2014-09-25 23:17:30 UTC 
Created attachment 287118 [details]
screenshot after the patch
Comment 6 Lapo Calamandrei 2014-09-26 10:38:39 UTC 
Comment 3 is for another bug... Sorry for the noise.
The patch it's not good, since it should we edit the sass, the css it's generated by the sass prepocessor, but thanks for pointing this out, I'll fix it.
Comment 7 Jakub Steiner 2014-09-26 13:39:28 UTC 
Created attachment 287158 [details] [review]
make dark links lighter/legible
Comment 8 Lapo Calamandrei 2014-09-26 15:10:55 UTC 
Created attachment 287172 [details] [review]
Fixes link style

Jakub, we already special case a lighter blue for the dark variant, let's not duplicate that for links, also the link style is a bit messy and actually *:link and -GtkWidget* need to do the same thing.
My patch takes care of all these issue.
Comment 9 Lapo Calamandrei 2014-09-26 16:28:15 UTC 
Created attachment 287197 [details] [review]
Fixes link style

Making visited links a different color is so 90s, got rid of that.
Comment 10 Matthias Clasen 2014-09-26 22:02:57 UTC 
Review of attachment 287197 [details] [review]:

I disagree that providing useful clues about what links you've already visited is 'so 90s'.
Comment 11 Lapo Calamandrei 2014-09-27 10:12:14 UTC 
the previous patch will do then, visited is contemplated there, anyway on the web :visited is not differently styled anymore in the vast majority of cases.
Comment 12 Lapo Calamandrei 2014-09-27 10:14:03 UTC 
PS. visited is not contemplated in what we have now eh