After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737383 - xsettings: Translate titlebar action settings
xsettings: Translate titlebar action settings
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xsettings
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
3.14.1
Depends on:
Blocks:
 
 
Reported: 2014-09-25 19:00 UTC by Matthias Clasen
Modified: 2014-09-26 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xsettings: Translate titlebar action settings (1.70 KB, patch)
2014-09-25 19:01 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2014-09-25 19:00:59 UTC 
GTK+ recently gained XSettings that match these settings.
This will make the behavior of CSD titlebars match that
of traditional titlebars, as far as possible.
Comment 1 Matthias Clasen 2014-09-25 19:01:02 UTC 
Created attachment 287102 [details] [review]
xsettings: Translate titlebar action settings
Comment 2 Matthias Clasen 2014-09-25 19:11:09 UTC 
The GTK+ commit is here: https://git.gnome.org/browse/gtk+/commit/?id=1d8a1a04f6c422a5668fee0d9069e973b921bd38

I heated a little and put it into the stable branch, since I think it would be good to resolve this in 3.14.1
Comment 3 Bastien Nocera 2014-09-26 09:23:24 UTC 
Review of attachment 287102 [details] [review]:

The code is alright, but the XSettings themselves look a little short-sighted or restrictive. What about button 5, button 6, key + a mouse button click, etc.?

Looks fine otherwise.
Comment 4 Matthias Clasen 2014-09-26 13:56:48 UTC 
no, not handling button 5, 6, 7 or anything else on titlebars. Ideally, we would just hardcode

double-click = toggle maximize
right-click = menu

but since we have these settings and they're exposed in the tweak-tool, it seems better to make them work for traditional and csd titlebars in the same way, instead of causing yet another headline about 'gnome is removing my precious setttings!'
Comment 5 Matthias Clasen 2014-09-26 14:06:14 UTC 
Attachment 287102 [details] pushed as 6e52754 - xsettings: Translate titlebar action settings