After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737346 - Please implement that Ctrl + u clears the password prompt
Please implement that Ctrl + u clears the password prompt
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-25 09:23 UTC by Paul Menzel
Modified: 2014-09-26 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-entry: Implement ctrl-u keybinding to clear the entry (985 bytes, patch)
2014-09-26 14:50 UTC, Florian Müllner
none Details | Review
st-entry: Implement ctrl-u keybinding to clear the entry (1.06 KB, patch)
2014-09-26 15:02 UTC, Florian Müllner
none Details | Review
st-entry: Implement Ctrl-u / Ctrl-k keybindings (1.53 KB, patch)
2014-09-26 20:05 UTC, Florian Müllner
committed Details | Review

Description Paul Menzel 2014-09-25 09:23:48 UTC
Forwarding bug report 658048 from the Debian BTS [1].

gdm3 does not appear to honor typing Ctrl-u to clear password
entry.  This behavior is common for unix password prompts, and
lacking this behavior is a regression from gdm.

[1] https://bugs.debian.org/658048
Comment 1 Ray Strode [halfline] 2014-09-25 13:33:41 UTC
previous discussion happened on bug 541958 which was NOTABUG'd, but now the login screen doesn't use GTK+ for entries, so maybe this should be revisited.

What do you think, Allan? Yay, or nay?
Comment 2 Matthias Clasen 2014-09-26 14:32:56 UTC
I actually see nothing wrong with just adding Ctrl-u as a binding in GtkEntry - I've just done that.
Comment 3 Florian Müllner 2014-09-26 14:36:07 UTC
... in which case doing the same in StEntry too makes a lot of sense
Comment 4 Florian Müllner 2014-09-26 14:50:37 UTC
Created attachment 287167 [details] [review]
st-entry: Implement ctrl-u keybinding to clear the entry

This keybinding is well-established on the CLI, and adding support
for it is cheap ...


I should add that I'm only aware of ctrl-u as "delete to the beginning of the line" keybinding (see readline); so not sure we'd rather want that instead of what the patch implements ...
(of course in the most common case - cursor at the line end - there is no difference at all)
Comment 5 Florian Müllner 2014-09-26 15:02:38 UTC
Created attachment 287168 [details] [review]
st-entry: Implement ctrl-u keybinding to clear the entry

For what it's worth, this is the "other" behavior (readline default, ...)

Both patches are trivial enough, so I don't care much (though we should pick whatever GTK ends up with of course)
Comment 6 Matthias Clasen 2014-09-26 17:26:09 UTC
I ended up with

Ctrl-u  delete to start of line
Ctrl-k  delete to end of line
Comment 7 Florian Müllner 2014-09-26 20:05:23 UTC
Created attachment 287208 [details] [review]
st-entry: Implement Ctrl-u / Ctrl-k keybindings

OK, let's go with that as well then.
Comment 8 Florian Müllner 2014-09-26 20:11:34 UTC
Attachment 287208 [details] pushed as 67b14d5 - st-entry: Implement Ctrl-u / Ctrl-k keybindings
Comment 9 Ray Strode [halfline] 2014-09-26 20:12:16 UTC
\o/