After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737243 - API break with tracker_indexing_tree_new()
API break with tracker_indexing_tree_new()
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
1.2.x
Other Linux
: Normal blocker
: ---
Assigned To: Martyn Russell
Depends on:
Blocks:
 
 
Reported: 2014-09-24 08:46 UTC by Martyn Russell
Modified: 2014-09-24 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes bug (6.12 KB, patch)
2014-09-24 09:00 UTC, Martyn Russell 		committed Details | Review
Fix vala bindings related to this API (837 bytes, patch)
2014-09-24 09:02 UTC, Martyn Russell 		committed Details | Review

Description Martyn Russell 2014-09-24 08:46:58 UTC 
fredp: martyn: do you have a bug number? we'll look at it as fast as possible.
martyn: fredp: not yet, ricotz noticed last night that I changed tracker_indexing_tree_new(void) -> tracker_indexing_tree(GFile *root) - where null is allowed for root
martyn: ricotz had a suggested patch which reverted that change and added a new API, tracker_indexing_tree_new_with_root()
martyn: I didn't notice and no one reviewing did either because it's not a common public API
fredp: ok, could you mail release-team@ once you get a bug number and patch?, we'll ack it quickly.
Comment 1 Martyn Russell 2014-09-24 09:00:49 UTC 
Created attachment 286955 [details] [review]
Fixes bug
Comment 2 Martyn Russell 2014-09-24 09:02:58 UTC 
Created attachment 286956 [details] [review]
Fix vala bindings related to this API

Related to this bug is a Vala binding update that is needed which we would like to be released with the above patch. This is how Ricotz noticed this in the first place!
Comment 3 Martyn Russell 2014-09-24 16:20:09 UTC 
This problem has been fixed in the development version. The fix is available in the next major software release. Thank you for your bug report.