After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737133 - Missing gstconfig.h include
Missing gstconfig.h include
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal normal
: 1.4.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-22 17:08 UTC by Marcin Kolny (IRC: loganek)
Modified: 2014-09-24 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed solution (618 bytes, patch)
2014-09-22 17:09 UTC, Marcin Kolny (IRC: loganek) 		none Details | Review
proposed solution v2 (664 bytes, patch)
2014-09-22 17:41 UTC, Marcin Kolny (IRC: loganek) 		committed Details | Review

Description Marcin Kolny (IRC: loganek) 2014-09-22 17:08:09 UTC 
Hi, I noticed, that there's a missing include gstconfig.h in gstdatetime.h file, so we can't just use gstdatetime.h file directly in our code. 
My patch fixes this problem, by adding include to a gstconfig.h file.
Comment 1 Marcin Kolny (IRC: loganek) 2014-09-22 17:09:28 UTC 
Created attachment 286828 [details] [review]
proposed solution
Comment 2 Marcin Kolny (IRC: loganek) 2014-09-22 17:41:59 UTC 
Created attachment 286833 [details] [review]
proposed solution v2

ups.. I forgot about GType and glib-object.h include.
Comment 3 Sebastian Dröge (slomo) 2014-09-23 16:27:48 UTC 
Note that you shouldn't include those at all yourself, but the patch is correct nonetheless.

commit 4707c0410ca89d2ab45c7da2d78f2746b6c6b462
Author: Marcin Kolny <marcin.kolny@flytronic.pl>
Date:   Mon Sep 22 19:05:32 2014 +0200

    datetime: added missing include directives
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737133