After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736999 - keyboard: Make sure to destroy the key's BoxPointer
keyboard: Make sure to destroy the key's BoxPointer
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-20 00:51 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-09-24 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Make sure to destroy the key's BoxPointer (1.59 KB, patch)
2014-09-20 00:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2014-09-20 00:51:07 UTC 
This fixes a major slowness problem I've been seeing
opening the message tray for the past few days.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-09-20 00:51:11 UTC 
Created attachment 286664 [details] [review]
keyboard: Make sure to destroy the key's BoxPointer

When the keyboard is destroyed, we destroy the keyboard actor, but the
keyboard's menu isn't part of the key itself, so it's never tracked.

The menus are actually tracked actors, so they slow down the layout
manager's code to rebuild regions and other things. Keeping this list
small is a good idea.

To prevent leaking menus, destroy the menu when the key is destroyed.
Comment 2 drago01 2014-09-20 16:16:18 UTC 
Review of attachment 286664 [details] [review]:

OK, marking as commit after freeze which means "either ask for a freeze exception if you think its worth it or wait for 3.14.1"
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-09-24 21:08:38 UTC 
Attachment 286664 [details] pushed as 9d93335 - keyboard: Make sure to destroy the key's BoxPointer