After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736900 - directsound: Status seems not checked
directsound: Status seems not checked
Status: RESOLVED DUPLICATE of bug 734098
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 13:16 UTC by Sanjay NM
Modified: 2014-10-09 05:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sanjay NM 2014-09-18 13:16:01 UTC 
In File gst-plugins-good\sys\gstdirectsoundssink.c line 553, IDirectSoundBuffer_Getstatus is done and result is put into hRes. It immediately gets overwritten without checking any status. Is this fine ?

Same at line 574, 677 - 680, 692, 745, ..
Request to please review.
Comment 1 Sebastian Dröge (slomo) 2014-09-18 13:20:32 UTC 
This is related to bug #734098

Did you test your changes?
Comment 2 Sebastian Dröge (slomo) 2014-09-23 17:00:47 UTC 
You also forgot to attach your patch :)
Comment 3 Sanjay NM 2014-09-24 06:28:01 UTC 
I have not fixed this yet, so have not attached it :-)
I think this is the same as #734098.
Will create a patch and submit soon ...
Comment 4 Sanjay NM 2014-10-09 05:30:24 UTC 
I do not have windows setup, so finding it difficult to fix this, can do the changes but compiling and testing is not looking feasible.
Will be good if this is marked as duplicate for bug #734098.

*** This bug has been marked as a duplicate of bug 734098 ***