After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736883 - dtmf: Removed unwanted structure member and assignment
dtmf: Removed unwanted structure member and assignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 11:33 UTC by Sanjay NM
Modified: 2014-09-19 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dtmf: Removed unwanted structure member and assignment (2.31 KB, patch)
2014-09-18 11:33 UTC, Sanjay NM 		none Details | Review
dtmf: Removed unused structure members (1.99 KB, patch)
2014-09-19 09:08 UTC, Sanjay NM 		committed Details | Review

Description Sanjay NM 2014-09-18 11:33:54 UTC 
Created attachment 286477 [details] [review]
dtmf: Removed unwanted structure member and assignment

Removed unwanted structure member and assignment
Comment 1 Olivier Crête 2014-09-18 14:22:53 UTC 
Review of attachment 286477 [details] [review]:

::: gst/dtmf/gstrtpdtmfdepay.c
@@ +109,3 @@
 typedef struct st_dtmf_key
 {
   const char *event_name;

While you're at it, the event_name isn't used either...
Comment 2 Sanjay NM 2014-09-19 09:08:49 UTC 
Created attachment 286604 [details] [review]
dtmf: Removed unused structure members

Removed event_name as per the review comment. Please find the patch attached
Comment 3 Olivier Crête 2014-09-19 19:42:46 UTC 
Committed

commit 89eb37859806f790195832f8f31cf82e816f42d6
Author: Sanjay NM <sanjay.nm@samsung.com>
Date:   Fri Sep 19 14:34:13 2014 +0530

    dtmf: Removed unused structure members
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736883