After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736877 - gsturi: Remove unnecessary code
gsturi: Remove unnecessary code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 11:18 UTC by RaviKiran
Modified: 2014-09-19 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use new_uri for set_uri method (745 bytes, patch)
2014-09-18 11:20 UTC, RaviKiran 		none Details | Review
gsturi remove unnecessary code (1.23 KB, patch)
2014-09-19 04:33 UTC, RaviKiran 		none Details | Review

Description RaviKiran 2014-09-18 11:18:14 UTC 
In gst_uri_handler_set_uri(), 'new_uri' is created using protocol and location, but isn't used.
1. It can be used for set_uri() OR
2. Can be removed
Comment 1 RaviKiran 2014-09-18 11:20:35 UTC 
Created attachment 286473 [details] [review]
use new_uri for set_uri method

patch attached for 1st option. Please review.
Comment 2 Luis de Bethencourt 2014-09-18 14:10:59 UTC 
Nice! new_uri is unused indeed.

Considering that new_uri is created from the split of the original uri's protocol and location. And those two never change during the function. new_uri will always be the same as uri.

Plus this never raised any bugs while it used uri in the iface->set_uri() line.

I think we can just remove the creation of new_uri and we use set_uri. So number 2 in your list of potential fixes.

As soon as you write this patch I will merge it for you :)

Thanks
Comment 3 RaviKiran 2014-09-19 04:33:28 UTC 
Created attachment 286558 [details] [review]
gsturi remove unnecessary code

Thanks for the review. Here is the new patch as you suggested.
Comment 4 Luis de Bethencourt 2014-09-19 09:59:09 UTC 
Great! I will merge this within the day.
Comment 5 Luis de Bethencourt 2014-09-19 15:29:11 UTC 
Merged.