After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736543 - matroska:OR and Bitwise OR of the same flag twice
matroska:OR and Bitwise OR of the same flag twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-12 08:40 UTC by Anuj
Modified: 2014-09-12 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
OR and bitwise OR of the same flag twice (1.76 KB, patch)
2014-09-12 08:40 UTC, Anuj 		committed Details | Review

Description Anuj 2014-09-12 08:40:30 UTC 
Created attachment 286005 [details] [review]
OR and bitwise OR of the same flag twice

In both files matroska-mux.c and matroska-demux.c Bitwise OR and OR of the same flag is done. please review.
Comment 1 Tim-Philipp Müller 2014-09-12 09:39:54 UTC 
Thanks for the patch. The matroskademux fix is not correct, it should check for 28_8 instead, the other chunk is fine of course:

commit 4242495ea74b0eccda8d5f8f32e69b1845624ccf
Author: Anuj Jaiswal <anuj.jaiswal@samsung.com>
Date:   Fri Sep 12 13:36:18 2014 +0530

    matroskamux: don't bitwise OR the same flag twice
    
    https://bugzilla.gnome.org//show_bug.cgi?id=736543

commit 4c08f2694d5998138bb2653892d9b688005e161c
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Sep 12 10:35:36 2014 +0100

    matroskademux: handle real audio 28_8
    
    Fixes duplicate check for 14_4.
    
    https://bugzilla.gnome.org//show_bug.cgi?id=736543
Comment 2 Anuj 2014-09-12 12:00:25 UTC 
Ok. Thanks for reviewing I'll make changes and add patch for the matroskademux also.
Comment 3 Tim-Philipp Müller 2014-09-12 12:04:02 UTC 
I've fixed it already now.