After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736497 - macros2: Add support for APPSTREAM_XML macro
macros2: Add support for APPSTREAM_XML macro
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-11 18:38 UTC by Bastien Nocera
Modified: 2014-09-12 08:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
macros2: Add support for APPSTREAM_XML macro (975 bytes, patch)
2014-09-11 18:38 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-09-11 18:38:30 UTC 
.
Comment 1 Bastien Nocera 2014-09-11 18:38:34 UTC 
Created attachment 285945 [details] [review]
macros2: Add support for APPSTREAM_XML macro

And request that appstream-xml.m4 get installed if missing.
Comment 2 David King 2014-09-12 06:56:01 UTC 
Review of attachment 285945 [details] [review]:

Looks good.
Comment 3 Bastien Nocera 2014-09-12 07:17:46 UTC 
Attachment 285945 [details] pushed as b23a0e0 - macros2: Add support for APPSTREAM_XML macro
Comment 4 Philip Withnall 2014-09-12 07:45:35 UTC 
Hrm. Shouldn’t we be not accepting further macros, and redirecting them to the autoconf-archive instead, David?
Comment 5 David King 2014-09-12 07:57:30 UTC 
This is not adding a macro, but adding a check to gnome-autogen that warns if APPSTREAM_XML appears in configure.ac but the M4 file is not present. I think that is fine.
Comment 6 Philip Withnall 2014-09-12 08:34:56 UTC 
I should totally read patches before commenting. :-\