Bug 736475 – 3.13.91: crash when attempting to change the background

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 736475 - 3.13.91: crash when attempting to change the background


Summary:	3.13.91: crash when attempting to change the background


Status:	RESOLVED FIXED

Product:	gnome-control-center
Classification:	Core
Component:	Background
Version:	3.13.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Debarshi Ray
QA Contact:	Control-Center Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-09-11 13:54 UTC by Dominique Leuenberger
Modified:	2014-10-23 09:33 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
background: Fix possible crash when date isn't available (1.09 KB, patch) 2014-10-20 11:42 UTC, Bastien Nocera	committed	Details \| Review

Description Dominique Leuenberger 2014-09-11 13:54:39 UTC

Start g-c-c, background, click on 'background' to choose a new one.

The window spawns, and a couple moments later g-c-c segfaults

a trace looks like:

+ Trace 234082

#0 g_date_time_to_instant
at gdatetime.c line 499
#1 g_date_time_to_unix
at gdatetime.c line 1900
#2 media_found_cb
at bg-pictures-source.c line 574
#3 media_found_cb
at bg-pictures-source.c line 897
#4 g_cclosure_marshal_VOID__OBJECTv
at gmarshal.c line 1312
#5 _g_closure_invoke_va
at gclosure.c line 831
#6 g_signal_emit_valist
at gsignal.c line 3218
#7 g_signal_emit
at gsignal.c line 3365
#8 is_online_data_cached
at cc-background-grilo-miner.c line 92
#9 g_task_return_now
at gtask.c line 1077
#10 complete_in_idle_cb
at gtask.c line 1086
#11 g_main_context_dispatch
at gmain.c line 3064
#12 g_main_context_dispatch
at gmain.c line 3663
#13 g_main_context_iterate
at gmain.c line 3734
#14 g_main_context_iteration
at gmain.c line 3795
#15 g_application_run
at gapplication.c line 2282
#16 main
at main.c line 49

Comment 1 Dominique Leuenberger 2014-09-11 14:42:35 UTC

It only happens when a flickr online-account is configured

Comment 2 Bastien Nocera 2014-09-11 15:20:00 UTC

Can't reproduce here because of https://bugzilla.gnome.org/show_bug.cgi?id=736487

Comment 3 Laurent Pointecouteau 2014-10-20 11:22:28 UTC

I'm having the same issue, except I don't have any Flickr account configured.
I'm using gnome-control-center-3.14.1-1 on Arch Linux.

Comment 4 Bastien Nocera 2014-10-20 11:42:21 UTC

Created attachment 288920 [details] [review]
background: Fix possible crash when date isn't available

Comment 5 Debarshi Ray 2014-10-20 11:58:25 UTC

Review of attachment 288920 [details] [review]:

Looks good to me.

::: panels/background/bg-pictures-source.c
@@ +573,3 @@
   mtime = grl_media_get_creation_date (media);
+  if (!mtime)
+    mtime = grl_media_get_modification_date (media);

Minor nitpick. Given that the comment says modification date is not implemented, reading it here seems a bit incongruous.

Comment 6 Debarshi Ray 2014-10-20 12:09:25 UTC

(In reply to comment #3)
> I'm having the same issue, except I don't have any Flickr account configured.
> I'm using gnome-control-center-3.14.1-1 on Arch Linux.

Do you have a backtrace?

Comment 7 Debarshi Ray 2014-10-23 09:33:46 UTC

I am going to close this bug. If you are still getting crashes, feel free to file a new bug with a backtrace.