After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736455 - valve: typo in drop property description
valve: typo in drop property description
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.x
Other Linux
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-11 07:41 UTC by Rémi Lefèvre
Modified: 2014-09-11 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for GStreamer master (930 bytes, patch)
2014-09-11 07:41 UTC, Rémi Lefèvre
committed Details | Review

Description Rémi Lefèvre 2014-09-11 07:41:16 UTC
Created attachment 285887 [details] [review]
Patch for GStreamer master

Description says "Any downstream error received while the “drop” property is FALSE is ignored.".

I think that valve actually ignores errors when drop is TRUE, not FALSE.

Patch for master attached.
Comment 1 Tim-Philipp Müller 2014-09-11 10:11:44 UTC
Thanks, fixed:

 commit 9b2231669f6f4a4052aeb52bae15790f27fb75f7
 Author: Rémi Lefèvre <remi.lefevre@parrot.com>
 Date:   Thu Sep 11 09:35:17 2014 +0200

    valve: fix typo in description
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736455