GNOME Bugzilla – Bug 736398
windowlist: Shows some windows multiple times (dual monitor)
Last modified: 2014-09-11 10:14:13 UTC
Not sure of the exact conditions that trigger it, but I often get windows showing up twice in the officially supported window-list extension. It requires that you have dual displays and that the window is on the secondary display. In my case I have the tweak "workspaces only on primary display" active (not sure if this is the default or not). It seems that the window is shown in the windowlist as many times as you have active worksplaces + 1 (i.e. the spare). It requires a shell restart to see the duplicate windows, but disabling+enabling the extension itself seems to fix it up.
sounds like something we should fix for classic mode in 3.14
Created attachment 285892 [details] [review] window-list: Do not add sticky windows more than once When a window's on-all-workspaces property changes to true, the workspaces the window was not located on will emit the ::window-added signal for the window; however we don't want multiple buttons for the same window, so filter out the extra calls.
Review of attachment 285892 [details] [review]: Looks good. I wonder though, if we should always check if we already have a button for a window instead of only when if (on_all_workspaces) ?
Review of attachment 285892 [details] [review]: Fixes the immediate problem for me - thanks! I've not looked at the code for grouping (I don't use this feature) but would this also handle the case of grouped windows OK if that option were turned on? Rui's suggestion of always checking seems reasonable too if it could prevent future edge cases (although not sure immediately what they are)
(In reply to comment #3) > I wonder though, if we should always check if we already have a button for a > window instead of only when if (on_all_workspaces) ? I wouldn't mind, I just couldn't think of anything that would require this in the !on_all_workspaces case ...
(In reply to comment #4) > I've not looked at the code for grouping (I don't use this feature) but would > this also handle the case of grouped windows OK if that option were turned on? Grouped windows aren't affected by this bug.
Attachment 285892 [details] pushed as 191c7cc - window-list: Do not add sticky windows more than once Pushed with the on_all_workspaces check removed.