After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736319 - dashdemux: mark first buffer as discont after restarting a download task
dashdemux: mark first buffer as discont after restarting a download task
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.4.1
Other All
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-09 11:23 UTC by Matthieu Bouron
Modified: 2014-10-14 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dashdemux: mark first buffer as discont after restarting a download task (2.18 KB, patch)
2014-09-09 11:25 UTC, Matthieu Bouron
accepted-commit_now Details | Review
dashdemux: push a time segment when restarting streaming (1.82 KB, patch)
2014-09-20 01:34 UTC, Thiago Sousa Santos
accepted-commit_now Details | Review

Description Matthieu Bouron 2014-09-09 11:23:49 UTC
Mark first buffer as discont after restarting a download task, so downstream can reset its state to properly handle the new fragment.
    
Related issue: https://bugzilla.gnome.org/show_bug.cgi?id=736318
Comment 1 Matthieu Bouron 2014-09-09 11:25:09 UTC
Created attachment 285730 [details] [review]
dashdemux: mark first buffer as discont after restarting a download task
Comment 2 Thiago Sousa Santos 2014-09-20 01:34:12 UTC
Created attachment 286667 [details] [review]
dashdemux: push a time segment when restarting streaming

It seems to work with this patch and the fix for qtdemux handling time segments properly.
But I also agree that we should mark the buffers as discont as well.
Comment 3 Thiago Sousa Santos 2014-09-24 17:21:16 UTC
commit 22c7559152f77c62e12f80bb33be5429144d46ad
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Tue Sep 9 13:12:31 2014 +0200

    dashdemux: mark first buffer as discont after restarting a download task
    
    Mark first buffer as discont after restarting a download task, so
    downstream can reset its state to properly handle the new fragment.
    
    Related issue: https://bugzilla.gnome.org/show_bug.cgi?id=736318
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736319

commit 2273c15f15bc2a847dc78bfeb309198d52557989
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Fri Sep 19 22:32:39 2014 -0300

    dashdemux: push a time segment when restarting streaming
    
    This should inform demuxers/decoders downstream that the stream is
    about to start from a new position and they should flush accordingly
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736319