Created attachment 285688 [details] [review]
network: hide airplane switch when g-s-d says so

Review of attachment 285688 [details] [review]:

Note that this will also require a freeze break to land.

::: panels/network/cc-network-panel.c
@@ +302,3 @@
+
+        gtk_widget_set_visible (GTK_WIDGET (panel->priv->kill_switch_header), enabled && should_show);
+        if (!enabled || !should_show)

No, we still need to hook this up, otherwise your code to check for changed properties in g-s-d is useless.

(In reply to comment #2)
> 
> Note that this will also require a freeze break to land.

You mean UI freeze break? The UI won't really be changed, unless we fall into the category of machines affected by the patch...

> No, we still need to hook this up, otherwise your code to check for changed
> properties in g-s-d is useless.

Not sure I follow; the code I changed runs after the property notification has already been received and only controls the active state/visibility/sensitivity of the switch.

(In reply to comment #3)
> (In reply to comment #2)
> > 
> > Note that this will also require a freeze break to land.
> 
> You mean UI freeze break? The UI won't really be changed, unless we fall into
> the category of machines affected by the patch...

Better safe than sorry.

> > No, we still need to hook this up, otherwise your code to check for changed
> > properties in g-s-d is useless.
> 
> Not sure I follow; the code I changed runs after the property notification has
> already been received and only controls the active state/visibility/sensitivity
> of the switch.

I missed the fact that it was in a sync_* call.

Review of attachment 285688 [details] [review]:

My mistake, looks good.

Attachment 285688 [details] pushed as 436d220 - network: hide airplane switch when g-s-d says so