After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736278 - [gnome-tetravex] time counter bugs
[gnome-tetravex] time counter bugs
Status: RESOLVED FIXED
Product: gnome-tetravex
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-tetravex-maint
gnome-tetravex-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-08 17:46 UTC by Arnaud B.
Modified: 2014-09-10 06:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix timer string in French translation (1.08 KB, patch)
2014-09-08 19:47 UTC, Michael Catanzaro
committed Details | Review
Fix timer string in French translation (1.08 KB, patch)
2014-09-08 19:49 UTC, Michael Catanzaro
committed Details | Review

Description Arnaud B. 2014-09-08 17:46:01 UTC
(fr) Le chronomètre est buggué, il y a un « <200e> » qui s’affiche au milieu. J’imagine que le problème est le même quand le jeu a été lancé plus d’une heure, à voir le code ; il y a deux chaînes de caractères à corriger. Mais je n’ai pas idée de ce que le traducteur essayait de faire…

(en) The time counter bugs, there’s a “<200e>” in its middle. I think the problem also exists when the game exceeded one hour, seeing the code; there’s two strings that should be corrected. But I don’t know what the translator wanted to do…
Comment 1 Claude Paroz 2014-09-08 18:04:56 UTC
The translation just copied the syntax of the original string. Either something doesn't work as expected in the code, or the translation comment is wrong.

#. Translators: sorry. This is the clock label when the game has exceeded
#. * one hour in length. The first %02d is hours, the middle %02d is minutes,
#. * and the last is seconds. In between are ratio characters and LTR order
#. * marks, so that nothing gets reversed in RTL languages. You probably do not
#. * need to change this. Probably.
#.
#: ../src/gnome-tetravex.vala:306
#, c-format
msgid "%02d∶<200e>%02d∶<200e>%02d"
msgstr "%02d∶<200e>%02d∶<200e>%02d"

#. Translators: sorry. This is the clock label when the game is less than
#. * one hour in length. The first %02d is minutes and the last is seconds.
#. * In between is a ratio character and LTR order mark, so that nothing gets
#. * reversed in RTL languages. You probably do not need to change this. Probably.
#.
#: ../src/gnome-tetravex.vala:315
#, c-format
msgid "%02d∶<200e>%02d"
msgstr "%02d∶<200e>%02d"
Comment 2 Arnaud B. 2014-09-08 18:39:26 UTC
I’m on Tetravex jhbuild’s master, and I read in the fr.po:

#. Translators: sorry. This is the clock label when the game has exceeded
#. * one hour in length. The first %02d is hours, the middle %02d is minutes,
#. * and the last is seconds. In between are ratio characters and LTR order
#. * marks, so that nothing gets reversed in RTL languages. You probably do not
#. * need to change this. Probably.
#.
#: ../src/gnome-tetravex.vala:306
#, c-format
msgid "%02d∶‎%02d∶‎%02d"
msgstr "%02d∶<200e>%02d∶<200e>%02d"

#. Translators: sorry. This is the clock label when the game is less than
#. * one hour in length. The first %02d is minutes and the last is seconds.
#. * In between is a ratio character and LTR order mark, so that nothing gets
#. * reversed in RTL languages. You probably do not need to change this. Probably.
#.
#: ../src/gnome-tetravex.vala:315
#, c-format
msgid "%02d∶‎%02d"
msgstr "%02d∶<200e>%02d"

Other translations (LANG=de_DE, LANG=it_IT…) doesn’t have this problem.
Comment 3 Arnaud B. 2014-09-08 18:40:33 UTC
Oh, and the problem exists in Rawhide, so it’s not my build.
Comment 4 Mario Wenzel 2014-09-08 19:05:35 UTC
Could there have been a problem with escaping somewhere during the process? I added Michael Catanzaro, who conjured those strings, to the bug's cc list.
Comment 5 Michael Catanzaro 2014-09-08 19:47:49 UTC
Looks like whatever tool you're using to create the French translation is choking on the LTR order marks. You should definitely file a new bug for this as otherwise your translation will surely break again in the future. For now I've just copied the correct string into place.

The following fix has been pushed:
2bb6f4e Fix timer string in French translation
Comment 6 Michael Catanzaro 2014-09-08 19:47:52 UTC
Created attachment 285672 [details] [review]
Fix timer string in French translation
Comment 7 Michael Catanzaro 2014-09-08 19:49:11 UTC
Second try's the charm.

The following fix has been pushed:
e19797c Fix timer string in French translation
Comment 8 Michael Catanzaro 2014-09-08 19:49:14 UTC
Created attachment 285674 [details] [review]
Fix timer string in French translation
Comment 9 Michael Catanzaro 2014-09-08 19:53:17 UTC
And if you're going to have to discuss this on a mailing list anyway (I imagine various translations for several games are probably affected; that string is copypasted into at least three or four different games), then it'd be good to discuss whether the timer string really needs to be marked for translation at all.

Some other developers are putting colons into the translatable strings and then programatically replacing them with a ratio character and LTR mark, but that seems like crazy overkill to me.
Comment 10 Claude Paroz 2014-09-09 17:50:27 UTC
Thanks for fixing this. For the record, I had edited the file with vim. I think it's a bit fragile to insert such non-printable characters in translatable strings. But I cannot come with a better proposal for now.
Comment 11 Michael Catanzaro 2014-09-10 00:11:02 UTC
In the Vala code I actually spelled out the hex values; I didn't realize they would be converted for translators.  And I'm quite surprised vim couldn't handle the LTR marks. Oh well.

I'm happy to make these strings untranslatable if everybody is just copying them unchanged.
Comment 12 Claude Paroz 2014-09-10 06:45:28 UTC
(In reply to comment #11)
... 
> I'm happy to make these strings untranslatable if everybody is just copying
> them unchanged.

This could be asked on the gnome-i18n mailing list.