After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736204 - LIBXSLT_DEFAULT_PLUGINS_PATH hard coded to $prefix/lib directory
LIBXSLT_DEFAULT_PLUGINS_PATH hard coded to $prefix/lib directory
Status: RESOLVED FIXED
Product: libxslt
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Daniel Veillard
libxml QA maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-06 19:10 UTC by larryhaja
Modified: 2015-12-10 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix hard coded plugins lib directory (551 bytes, patch)
2014-09-06 19:10 UTC, larryhaja
none Details | Review

Description larryhaja 2014-09-06 19:10:37 UTC
Created attachment 285585 [details] [review]
Patch to fix hard coded plugins lib directory

The LIBXSLT_DEFAULT_PLUGINS_PATH variable in configure.in is hard coded with a lib directory that doesn't allow for other lib locations (eg. /usr/lib64 on some x86_64 systems).  On my x86_64 system I see this in the config and the libxslt library.

bash-4.2$ /usr/bin/xslt-config --plugins
/usr/lib/libxslt-plugins
bash-4.2$ strings /usr/lib64/libxslt.so.1.1.28 | grep plugins
/usr/lib/libxslt-plugins
bash-4.2$ ls -ld /usr/lib64/libxslt-plugins
drwxr-xr-x 2 root root 4096 Jun  9  2013 /usr/lib64/libxslt-plugins

This hard coded lib directory can be fixed by using the $libdir variable instead of the $module_prefix/lib variable/lib combination.  A patch is attached.
Comment 1 Nick Wellnhofer 2014-09-28 12:42:17 UTC
Fixed with the following commit:

https://git.gnome.org/browse/libxslt/commit/?id=35caed042e3e3b777cf0bbc6aa02bb947da11835
Comment 2 David Kilzer 2015-12-05 22:47:02 UTC
This causes the following string in xsltconfig.h when regenerating files using autoconf, which is not correct:

--- xsltconfig.h   
+++ xsltconfig.h   
@@ -120,7 +120,7 @@
 #ifndef WITH_MODULES
 #define WITH_MODULES
 #endif
-#define LIBXSLT_DEFAULT_PLUGINS_PATH() "/usr/lib/libxslt-plugins"
+#define LIBXSLT_DEFAULT_PLUGINS_PATH() "${exec_prefix}/lib/libxslt-plugins"
 #endif
 
 /**

This bug should be reopened and/or the commit should be backed out or fixed.
Comment 3 Nick Wellnhofer 2015-12-06 21:02:25 UTC
Fixed for real with the following commit:

https://git.gnome.org/browse/libxslt/commit/?id=698a23d4e5f94bfcde93af55e03552927d8020ad
Comment 4 David Kilzer 2015-12-10 18:40:05 UTC
(In reply to Nick Wellnhofer from comment #3)
> Fixed for real with the following commit:
> 
> https://git.gnome.org/browse/libxslt/commit/
> ?id=698a23d4e5f94bfcde93af55e03552927d8020ad

Thanks Nick!