Created attachment 285537 [details] [review]
sidebar: Fix sidebar-route-info alignment

time-info was pushing distance-info with margin, that can break the
alignment when time-info's length change.

The reason to use the sidebar-route-info-wrapper GtkGrid was to avoid
a visual glitch in the map view caused when we attempt to expand
horizontally a direct child of a sidebar's container.

Review of attachment 285537 [details] [review]:

Tried for a while to do away with the wrapper grid but failed.

Do we know where the "glitch" comes from?

::: src/sidebar.ui
@@ +184,3 @@
             <property name="can_focus">False</property>
+            <property name="margin_start">17</property>
+            <property name="margin_end">17</property>

Why 17? Is it to much? Why not 10 like the entry images for instance?

Review of attachment 285537 [details] [review]:

The glitch started comes from "09becd Have sidebar push the map on reveal". I needed to hack the route entries's hexpand in that commit to avoid the glitch.

::: src/sidebar.ui
@@ +184,3 @@
             <property name="can_focus">False</property>
+            <property name="margin_start">17</property>
+            <property name="margin_end">17</property>

The entry images have 15 for margin-start and the buttons have 12 for margin-end, anyways I didn't use the same values, I set the margin by hand with Inspector until it looks well-aligned with images and buttons.

Review of attachment 285537 [details] [review]:

ack.

Attachment 285537 [details] pushed as 217ab58 - sidebar: Fix sidebar-route-info alignment