After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736047 - qtdemux: check we have a corresponding stream after parsing a tfhd node
qtdemux: check we have a corresponding stream after parsing a tfhd node
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.1
Other Linux
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-04 12:25 UTC by Matthieu Bouron
Modified: 2016-02-22 07:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: check we have a corresponding stream after parsing a tfhd node (1.07 KB, patch)
2014-09-04 12:26 UTC, Matthieu Bouron 		reviewed Details | Review

Description Matthieu Bouron 2014-09-04 12:25:34 UTC 
Fixes a crash when there is no playable streams and qtdemux_parse_moof is
called by gst_qtdemux_process_adapter, using the following sample:

http://yt-dash-mse-test.commondatastorage.googleapis.com/media/car_cenc-20120827-manifest.mpd

The issue is visible when the application code does not seem to handle properly (or quick enough) the error related to DRM usage.
Comment 1 Matthieu Bouron 2014-09-04 12:26:47 UTC 
Created attachment 285359 [details] [review]
qtdemux: check we have a corresponding stream after parsing a tfhd node
Comment 2 Sebastian Dröge (slomo) 2014-09-04 12:39:40 UTC 
Review of attachment 285359 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +2794,3 @@
         qtdemux_tree_get_child_by_type_full (traf_node, FOURCC_tfdt,
         &tfdt_data);
+    if (tfdt_node && stream) {

Or maybe if we have no stream we shouldn't even get to this code here or at least not ask for the tfdt node?
Comment 3 Sebastian Dröge (slomo) 2014-09-17 17:25:04 UTC 
Why is this a blocker?
Comment 4 Thiago Sousa Santos 2015-01-21 12:15:43 UTC 
Ping
Comment 5 Edward Hervey 2016-02-22 07:50:51 UTC 
This doesn't crash anymore. The stream is properly detected/reported as being encrypted.