After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735966 - Subtitle in the "two line renderer" not dimmed
Subtitle in the "two line renderer" not dimmed
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-03 12:23 UTC by Bastien Nocera
Modified: 2014-09-03 15:40 UTC
See Also:
GNOME target: 3.14
GNOME version: ---


Attachments
two-lines-renderer: Fix subtitle not being applied (2.46 KB, patch)
2014-09-03 15:27 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2014-09-03 12:23:25 UTC
As can be seen with a recent version of GTK+ and gnome-documents or totem.
Comment 1 Matthias Clasen 2014-09-03 13:07:54 UTC
the hack in the twoline renderer just takes the font out of the dim-label - but we changed dim-label to use opacity now
Comment 2 Bastien Nocera 2014-09-03 13:10:04 UTC
It also uses the subtitle class, which does have font changes. The font size is supposed to change to 82% of its default value, and it doesn't do that.
Comment 3 Bastien Nocera 2014-09-03 15:27:29 UTC
Created attachment 285259 [details] [review]
two-lines-renderer: Fix subtitle not being applied

With recent versions of Adwaita/GTK+.

Apply all the necessary changes by hand, rather than relying on a
GtkStyleContext being able to transfer its style to a PangoLayout.
Comment 4 Bastien Nocera 2014-09-03 15:40:06 UTC
Attachment 285259 [details] pushed as ecef46a - two-lines-renderer: Fix subtitle not being applied