After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735932 - Crash when turning on airplane mode
Crash when turning on airplane mode
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
3.10.x
Other Linux
: Normal critical
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-02 21:53 UTC by Michael Catanzaro
Modified: 2014-09-03 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Fix possible crash when wireless-enabled changes (1.26 KB, patch)
2014-09-03 11:21 UTC, Bastien Nocera 		committed Details | Review
network: Fix more potential crashers for WWAN (2.32 KB, patch)
2014-09-03 11:25 UTC, Bastien Nocera 		committed Details | Review

Description Michael Catanzaro 2014-09-02 21:53:59 UTC 
* Visit the network panel
* Turn off the fake wifi hotspot (see bug #723643 -- no matter what I do, the network panel reports I'm running a wifi hotspot...)
* Exit the panel and return. The fake wifi hotspot is back. Turn it off again.
* Click the airplane mode toggle to turn on airplane mode. Crash.  (Alas, not reliably reproducible, but not uncommon either.)

+ Trace 234042

  • #0 net_device_get_nm_device
    at net-device.c line 230
  • #1 wireless_enabled_toggled
    at net-device-wifi.c line 248
  • #2 g_closure_invoke
    at gclosure.c line 777
  • #3 signal_emit_unlocked_R
    at gsignal.c line 3586
  • #4 g_signal_emit_valist
    at gsignal.c line 3330
  • #5 g_signal_emit
    at gsignal.c line 3386
  • #6 g_object_dispatch_properties_changed
    at gobject.c line 1047
  • #7 g_object_notify_by_spec_internal
    at gobject.c line 1141
  • #8 g_object_notify
    at gobject.c line 1183
  • #9 deferred_notify_cb
    at nm-object.c line 517
  • #10 g_main_dispatch
    at gmain.c line 3066
  • #11 g_main_context_dispatch
    at gmain.c line 3642
  • #12 g_main_context_iterate
    at gmain.c line 3713
  • #13 g_main_context_iteration
    at gmain.c line 3774
  • #14 g_application_run
    at gapplication.c line 1635
  • #15 main
    at main.c line 49 






Comment 1


Bastien Nocera





          2014-09-03 11:21:36 UTC
        



Created attachment 285248 [details] [review]
network: Fix possible crash when wireless-enabled changes

The device we're handling might have disappeared already, but we're
listening on the NMClient object, which is still alive.






Comment 2


Bastien Nocera





          2014-09-03 11:25:30 UTC
        



Created attachment 285249 [details] [review]
network: Fix more potential crashers for WWAN

And virtual devices. Again, listening on the long-lasting client
object but expecting the user_data (the object) to be around when
it might have been destroyed already.






Comment 3


Bastien Nocera





          2014-09-03 16:16:43 UTC
        



Attachment 285248 [details] pushed as a19c7ec - network: Fix possible crash when wireless-enabled changes
Attachment 285249 [details] pushed as c515a6e - network: Fix more potential crashers for WWAN