After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735808 - oggdemux: should not set segment.base in gst_ogg_pad_submit_packet()
oggdemux: should not set segment.base in gst_ogg_pad_submit_packet()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-01 13:06 UTC by Guillaume Desmottes
Modified: 2014-09-01 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
oggdemux: don't set segment.base in pad_submit_packet() (1.96 KB, patch)
2014-09-01 13:12 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2014-09-01 13:06:35 UTC
If you try playing an ogg file and send a seek request right away with (start=$X-seconds, stop=-1) you have to wait $X-seconds before the playback actually start.

This is another issue introduced with the fix for bug #706569 : setting Segment.base = time in gst_ogg_pad_submit_packet() result in the sink waiting $time before playing its buffer.
Comment 1 Guillaume Desmottes 2014-09-01 13:12:07 UTC
Created attachment 285012 [details] [review]
oggdemux: don't set segment.base in pad_submit_packet()

Setting segment.base in the segment sent from gst_ogg_demux_handle_page() is
enough to ensure that chained oggs are played corretly (see bgo#706569).

Tweaking the base in gst_ogg_pad_submit_packet() as well result in delays when
playing a file with start != -1.
Comment 2 Sebastian Dröge (slomo) 2014-09-01 13:26:48 UTC
commit be1b5b3de7954edea1186aca476d59ef1e42ad77
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Mon Sep 1 15:06:51 2014 +0200

    oggdemux: don't set segment.base in pad_submit_packet()
    
    Setting segment.base in the segment sent from gst_ogg_demux_handle_page() is
    enough to ensure that chained oggs are played corretly (see bgo#706569).
    
    Tweaking the base in gst_ogg_pad_submit_packet() as well result in delays when
    playing a file with start != -1.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735808