After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735777 - media-keys: Postpone initialisation of libcanberra
media-keys: Postpone initialisation of libcanberra
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-31 23:30 UTC by Bastien Nocera
Modified: 2014-09-01 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Postpone initialisation of libcanberra (4.07 KB, patch)
2014-08-31 23:30 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-08-31 23:30:43 UTC 
.
Comment 1 Bastien Nocera 2014-08-31 23:30:47 UTC 
Created attachment 284966 [details] [review]
media-keys: Postpone initialisation of libcanberra

It's possible for gnome-settings-daemon to block for the initialisation
of PulseAudio on startup, especially as some of PulseAudio's
enumerations could take a while.

Instead of initialising libcanberra on startup, initialise it when we're
actually going to use it the first time. Given that this happens in a
volume media key handling function, there's a good chance that
PulseAudio will already be initialised at that point.

See https://bugzilla.gnome.org/show_bug.cgi?id=645756#c3
Comment 2 Rui Matos 2014-09-01 07:27:53 UTC 
Review of attachment 284966 [details] [review]:

Didn't test, but looks fine
Comment 3 Bastien Nocera 2014-09-01 12:30:52 UTC 
Attachment 284966 [details] pushed as 2f6f42f - media-keys: Postpone initialisation of libcanberra