GNOME Bugzilla – Bug 735455
Many high contrast SVG icons are red circles
Last modified: 2014-09-10 12:22:29 UTC
/usr/share/icons/HighContrast/scalable/devices/scanner.svg is a red circle. This is really bad because the shell for some reason renders this red circle for the simple-scan app icon when using the High Contrast theme. A red circle does not represent a scanner, nor is it high contrast. /usr/share/icons/HighContrast/256x256/devices/scanner.png however is *not* a red circle.
That file is https://git.gnome.org/browse/gnome-themes-standard/plain/themes/HighContrast/icons/scalable/devices/scanner.svg However that file was supposed to be removed from Git: https://git.gnome.org/browse/gnome-themes-standard/commit/themes/HighContrast/icons/scalable/devices/scanner.svg?id=fa3e9399e09801fa7626f1bc2e64a30a403bbe9d Not sure what's going on.
https://git.gnome.org/browse/gnome-themes-standard/commit/themes/HighContrast/icons/scalable/devices/scanner.svg?id=4f932010268460b5dedc12717669e186440ff38c It seems this was reverted by Jakub
The plan is to use recolorable symbolic icons for the high contrast theme, but some issues, mainly the gtk2 side, are still unresolved. I pushed the changes prematurely by accident. More context in bug #732521
There are tons of red circle icons still. It'd be better to drop these icons than to leave them red circles....
Created attachment 284780 [details] All the broken icons -- screenshot one
By the way, I bet most or all of these have fine PNG icons, so you could make them work by just deleting the SVG variants.
Created attachment 284781 [details] broken icons -- screenshot two
Created attachment 284782 [details] broken icons -- screenshot thtree
Going back to the original bug report: simple-scan should just not rely on a generic themed icon, but ship a proper app icon itself, in both full-color and high-constrast versions.
As for all the red dots: they are all in the scalable part of the theme. Why are we installing svgs anyway, wasn't the idea a few years ago that we woudn't do that ?
as a quick experiment, emptying out /usr/share/icons/HighContrast/scalable (and regenerating the icon cache) makes all the problems go away: - no more red dots - simple-scan has a hc icon - dictionary uses a proper hc icon
Created attachment 285733 [details] [review] remove red dot placeholders - fullcolor is still a better fallback than red dot - many have been covered by rendered symbolic already
Proper fix for all this is making sure -symbolic has full coverage and switching to that for HC (bug #732521).
Created attachment 285743 [details] [review] Remove more red dot placeholders Jakub, either your patch missed a lot of red dots, or else my librsvg (Fedora 20) disagrees with yours as to what constitutes a red dot.
all red dots are gone