After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735417 - macros2: Deprecate GNOME_MAINTAINER_MODE_DEFINES
macros2: Deprecate GNOME_MAINTAINER_MODE_DEFINES
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-25 23:15 UTC by Philip Withnall
Modified: 2014-08-28 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
macros2: Deprecate GNOME_MAINTAINER_MODE_DEFINES (1.44 KB, patch)
2014-08-25 23:16 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-08-25 23:15:45 UTC 
Patch coming. Maintainers who really want to use it should just use AM_MAINTAINER_MODE directly.
Comment 1 Philip Withnall 2014-08-25 23:16:09 UTC 
Created attachment 284460 [details] [review]
macros2: Deprecate GNOME_MAINTAINER_MODE_DEFINES

The modules which it deprecates are all ancient and unused. Many of the
modules which use GNOME_MAINTAINER_MODE_DEFINES don’t make use of the
DISABLE_DEPRECATED variable it generates anyway.

If a module really wants maintainer mode, they should use
AM_MAINTAINER_MODE. Otherwise, they should just eliminate this call
entirely.
Comment 2 David King 2014-08-26 07:39:59 UTC 
Review of attachment 284460 [details] [review]:

Looks fine to me.
Comment 3 Philip Withnall 2014-08-28 17:46:28 UTC 
Attachment 284460 [details] pushed as b62c76f - macros2: Deprecate GNOME_MAINTAINER_MODE_DEFINES